Skip to content

WIP: ♻️ refactor licensed_items #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

WIP: ♻️ refactor licensed_items #7189

wants to merge 2 commits into from

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Feb 7, 2025

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Feb 7, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Singularity milestone Feb 7, 2025
@matusdrobuliak66 matusdrobuliak66 changed the title WIP: ♻️ refactor license_items WIP: ♻️ refactor licensed_items Feb 7, 2025
@codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.23129% with 32 lines in your changes missing coverage. Please review.

Project coverage is 75.02%. Comparing base (eee4eb2) to head (4673d3f).

❗ There is a different number of reports uploaded between BASE (eee4eb2) and HEAD (4673d3f). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (eee4eb2) HEAD (4673d3f)
unittests 30 21
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7189       +/-   ##
===========================================
- Coverage   87.71%   75.02%   -12.70%     
===========================================
  Files        1641     1326      -315     
  Lines       64177    54445     -9732     
  Branches     1179      857      -322     
===========================================
- Hits        56293    40847    -15446     
- Misses       7573    13358     +5785     
+ Partials      311      240       -71
Flag Coverage Δ
integrationtests 59.80% <ø> (-19.42%) ⬇️
unittests 73.48% <78.23%> (-12.63%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.49% <100.00%> (+0.10%) ⬆️
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 74.13% <0.00%> (ø)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <ø> (ø)
api_server ∅ <ø> (∅)
autoscaling 96.08% <ø> (ø)
catalog 91.47% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 77.01% <ø> (+0.08%) ⬆️
director_v2 91.30% <ø> (+0.01%) ⬆️
dynamic_scheduler 97.17% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.84% <93.93%> (-0.11%) ⬇️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 52.17% <ø> (-34.11%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee4eb2...4673d3f. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.3% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov will be requested when the pull request is marked ready for review pcrespov is a code owner

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg will be requested when the pull request is marked ready for review sanderegg is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK will be requested when the pull request is marked ready for review GitHK is a code owner

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis bisgaard-itis will be requested when the pull request is marked ready for review bisgaard-itis is a code owner

@wvangeit wvangeit Awaiting requested review from wvangeit wvangeit will be requested when the pull request is marked ready for review wvangeit is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo giancarloromeo will be requested when the pull request is marked ready for review giancarloromeo is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

None yet

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

1 participant

@matusdrobuliak66