Skip to content

♻️ introduce licensed_resources (🗃️) #7190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 10, 2025
Merged

♻️ introduce licensed_resources (🗃️) #7190

merged 9 commits into from
Feb 10, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Feb 9, 2025 •
edited
Loading

What do these changes do?

  • ♻️ introduce licensed_resources (🗃️)
    The same license can have multiple VIP models bundled together. Therefore, we need to extend the logic of licensed_items to support this use case. This PR is the first small step toward achieving that.

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Feb 9, 2025
@matusdrobuliak66 matusdrobuliak66 added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Feb 9, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Singularity milestone Feb 9, 2025
@codecov
Copy link

codecov bot commented Feb 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.52941% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.25%. Comparing base (3bb98a6) to head (0da143c).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7190      +/-   ##
==========================================
+ Coverage   87.03%   88.25%   +1.22%     
==========================================
  Files        1644     1425     -219     
  Lines       64231    57057    -7174     
  Branches     1186      699     -487     
==========================================
- Hits        55901    50356    -5545     
+ Misses       8018     6533    -1485     
+ Partials      312      168     -144
Flag Coverage Δ
integrationtests 65.31% <46.80%> (+1.94%) ⬆️
unittests 86.33% <98.52%> (+1.01%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.56% <100.00%> (+0.02%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.25% <100.00%> (+0.03%) ⬆️
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.51% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.68% <ø> (+0.09%) ⬆️
director_v2 91.30% <ø> (+0.04%) ⬆️
dynamic_scheduler 97.17% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.62% <ø> (-0.33%) ⬇️
storage 86.22% <ø> (+0.05%) ⬆️
webclient ∅ <ø> (∅)
webserver 84.77% <97.87%> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb98a6...0da143c. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review February 9, 2025 10:50
@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ introduce licensed_resources ♻️ introduce licensed_resources (🗃️) Feb 9, 2025
sanderegg
sanderegg approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) February 10, 2025 12:09
pcrespov
pcrespov approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 merged commit 7457535 into ITISFoundation:master Feb 10, 2025
92 of 94 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the vip-models-split-licensed-items-2-attempt branch February 10, 2025 15:25
@pcrespov pcrespov mentioned this pull request Feb 11, 2025
Merged
1 task
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 @mrnicegyu11
♻️ introduce licensed_resources (🗃️) (ITISFoundation#7190)
6969ed5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

5 participants

@matusdrobuliak66 @giancarloromeo @GitHK @pcrespov @sanderegg