Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 13, 2025

What do these changes do?

There is no to give internet access to services on this network.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Feb 13, 2025
@GitHK GitHK added the t:maintenance Some planned maintenance work label Feb 13, 2025
@GitHK GitHK added this to the Singularity milestone Feb 13, 2025
@GitHK GitHK marked this pull request as ready for review February 13, 2025 06:10
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (62c8a09) to head (41968bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7222      +/-   ##
==========================================
+ Coverage   87.02%   87.05%   +0.03%     
==========================================
  Files        1654     1647       -7     
  Lines       64435    64245     -190     
  Branches     1095     1095              
==========================================
- Hits        56073    55930     -143     
+ Misses       8049     8002      -47     
  Partials      313      313              
Flag Coverage Δ
integrationtests 65.32% <ø> (+<0.01%) ⬆️
unittests 86.04% <ø> (+0.03%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.53% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.25% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.48% <ø> (ø)
pkg_settings_library 90.61% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.95% <ø> (-0.22%) ⬇️
storage 86.28% <ø> (+0.11%) ⬆️
webclient ∅ <ø> (∅)
webserver 84.80% <ø> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c8a09...41968bc. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GitHK GitHK enabled auto-merge (squash) February 13, 2025 09:00
@GitHK GitHK merged commit c53197d into ITISFoundation:master Feb 13, 2025
91 of 94 checks passed
@GitHK GitHK deleted the pr-osparc-internal-doceker-api-network branch February 13, 2025 09:06
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 docker-api-network shall be internal

3 participants