-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] ViP Market: Requests after review 02.19 #7249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 (added @dyollb on the reviewers list)
|
dyollb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok I think, except for the javascript
services/static-webserver/client/source/class/osparc/vipMarket/AnatomicalModelDetails.js
Show resolved
Hide resolved
|
the gif doesn't show the regional models. what happened to the IXI (and potentially MIDA, etc.)? |
The animation comes from my local deployment, where only a few models are set up |



What do these changes do?
categoryIdtogether with themodelIdto the Sim4Life app for Importing modelRelated issue/s
How to test
Dev-ops checklist