Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 19, 2025

What do these changes do?

  • Rename: "Market" -> "Model Market"
  • "Rented" and "Open Access Models" categories -> Merged into "My Models" category
  • Terms and Conditions link accessible in model's features
  • Bundled items in vertical with Name + Functionality (Static by default) next to them
  • Sentence accepting Terms instead of checkbox
  • Remove bundle info from Rental section
  • Replace the currently purchased table by user friendly sentences
  • Remove "Available for Importing" text if "Import" button is enabled
  • Wallet's name on top of the credits indicator
  • Pass the categoryId together with the modelId to the Sim4Life app for Importing model

ModelMarket

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added this to the Singularity milestone Feb 19, 2025
@odeimaiz odeimaiz self-assigned this Feb 19, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Feb 19, 2025
@odeimaiz odeimaiz marked this pull request as ready for review February 19, 2025 16:34
@pcrespov pcrespov requested a review from dyollb February 19, 2025 17:07
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (added @dyollb on the reviewers list)

@sonarqubecloud
Copy link

Copy link
Member

@dyollb dyollb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok I think, except for the javascript

@dyollb
Copy link
Member

dyollb commented Feb 19, 2025

the gif doesn't show the regional models. what happened to the IXI (and potentially MIDA, etc.)?

@odeimaiz
Copy link
Member Author

the gif doesn't show the regional models. what happened to the IXI (and potentially MIDA, etc.)?

The animation comes from my local deployment, where only a few models are set up

@odeimaiz odeimaiz merged commit 9d6f156 into ITISFoundation:master Feb 20, 2025
57 checks passed
@odeimaiz odeimaiz deleted the enh/review-19-02 branch February 20, 2025 09:54
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants