Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 21, 2025

What do these changes do?

As suggested by @dyollb in #7249 (comment), this PR implements the LicensedItem and its LicensedItemResource data models to reduce the number of places where magic strings are used. Both models are also cached.

(accidentally includes #7258)

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Feb 21, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Feb 21, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Feb 21, 2025
@odeimaiz odeimaiz changed the title ✨ ViP Store: Licensed Item model and cache ✨ ViP Store: Licensed Item model and Cache Feb 21, 2025
@odeimaiz odeimaiz changed the title ✨ ViP Store: Licensed Item model and Cache ♻️✨ ViP Store: Licensed Item model and Cache Feb 21, 2025
@odeimaiz odeimaiz marked this pull request as ready for review February 21, 2025 16:42
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sonarqubecloud
Copy link

@odeimaiz odeimaiz merged commit fdd64ed into ITISFoundation:master Feb 24, 2025
57 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants