Skip to content

🐛 [Frontend] File Picker: complete upload #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
odeimaiz merged 8 commits into from
Mar 3, 2025
Merged

🐛 [Frontend] File Picker: complete upload #7299

odeimaiz merged 8 commits into from
Mar 3, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 3, 2025 •
edited
Loading

What do these changes do?

The bug was actually detected, but the solution was wrong. This PR fixes the fix 👌

Do not listen to output related backend updates if the node is a frontend node.
The frontend controls its output values, progress and states.
If a File Picker is uploading a file, the backend could override the current state with some older state.

During the debugging I found another bug:
ITISFoundation/osparc-issues#1858

OK, I wasn't able to reproduce it, but I believe I found the issue.
Before

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added this to the The Awakening milestone Mar 3, 2025
@odeimaiz odeimaiz self-assigned this Mar 3, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Mar 3, 2025
@odeimaiz odeimaiz marked this pull request as ready for review March 3, 2025 15:17
@odeimaiz odeimaiz enabled auto-merge (squash) March 3, 2025 15:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sanderegg
sanderegg approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice GIF! thanks!

@odeimaiz odeimaiz merged commit b7ac77b into ITISFoundation:master Mar 3, 2025
57 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@odeimaiz @mrnicegyu11
🐛 [Frontend] File Picker: complete upload (ITISFoundation#7299)
34e848a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@pcrespov pcrespov Awaiting requested review from pcrespov

@mguidon mguidon Awaiting requested review from mguidon

@Konohana0608 Konohana0608 Awaiting requested review from Konohana0608

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

3 participants

@odeimaiz @sanderegg @matusdrobuliak66