Skip to content

🐛 EFS - background task not starting #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 7, 2025
Merged

🐛 EFS - background task not starting #7314

merged 7 commits into from
Mar 7, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Mar 6, 2025

What do these changes do?

🐛 EFS - background task not starting

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 added this to the The Awakening milestone Mar 6, 2025
@matusdrobuliak66 matusdrobuliak66 self-assigned this Mar 6, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review March 6, 2025 14:29
sanderegg
sanderegg reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting

@codecov
Copy link

codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.00%. Comparing base (f7ce90e) to head (a5327b0).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f7ce90e) and HEAD (a5327b0). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (f7ce90e) HEAD (a5327b0)
unittests 30 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7314       +/-   ##
===========================================
- Coverage   87.32%   68.00%   -19.32%     
===========================================
  Files        1693      683     -1010     
  Lines       65785    32051    -33734     
  Branches     1121      168      -953     
===========================================
- Hits        57445    21796    -35649     
- Misses       8020    10197     +2177     
+ Partials      320       58      -262
Flag Coverage Δ
integrationtests 65.40% <ø> (+0.01%) ⬆️
unittests 89.79% <0.00%> (+3.31%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.57% <ø> (-12.73%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.10% <ø> (-0.98%) ⬇️
efs_guardian 89.79% <0.00%> (-0.46%) ⬇️
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.41% <ø> (-26.39%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ce90e...a5327b0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) March 6, 2025 15:47
pcrespov
pcrespov approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 merged commit 5075fe0 into ITISFoundation:master Mar 7, 2025
88 of 95 checks passed
matusdrobuliak66 added a commit to matusdrobuliak66/osparc-simcore that referenced this pull request Mar 7, 2025
@matusdrobuliak66
🐛 EFS - background task not starting (ITISFoundation#7314)
52a9c25
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 @mrnicegyu11
🐛 EFS - background task not starting (ITISFoundation#7314)
c700e25
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

a:efs-guardian

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

4 participants

@matusdrobuliak66 @GitHK @pcrespov @sanderegg