🎨Autoscaling monitor: allow SSH tunneling for DB access, and add return value for CLI usage #7329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
force-pushed
the
maintenance/autoscaling-monitoring-script
branch
from
dae50b1 to
79a7bbb
Compare
sanderegg
requested review from
GitHK,
YuryHrytsuk,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66 and
pcrespov
matusdrobuliak66
approved these changes
Mar 10, 2025
pcrespov
approved these changes
Mar 10, 2025
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
nice!
At some point i would really like to bring all these pyproject/uv/cli magic to our services :-)
scripts/maintenance/computational-clusters/autoscaled_monitor/cli.py
Outdated
Show resolved
Hide resolved
scripts/maintenance/computational-clusters/autoscaled_monitor/cli.py
Outdated
Show resolved
Hide resolved
GitHK
approved these changes
Mar 10, 2025
Contributor
GitHK
left a comment
GitHK
left a comment
There was a problem hiding this comment.
I wonder how well this uv lock file works instead of the classic complied dependencies.
scripts/maintenance/computational-clusters/autoscaled_monitor/db.py
Outdated
Show resolved
Hide resolved
scripts/maintenance/computational-clusters/autoscaled_monitor/core.py
Outdated
Show resolved
Hide resolved
scripts/maintenance/computational-clusters/autoscaled_monitor/cli.py
Outdated
Show resolved
Hide resolved
sanderegg
force-pushed
the
maintenance/autoscaling-monitoring-script
branch
from
f2f86c5 to
fcc97d6
Compare
|
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Mar 26, 2025
…rn value for CLI usage (ITISFoundation#7329)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Autoscaling monitoring package now can talk to DB via SSH tunnel using Ansible inventory
test-database-connectioncommandBonus:
Related issue/s
How to test
Dev-ops checklist