Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 10, 2025

What do these changes do?

Fixes the following issue

 log_msg=Skipping 'simcore/services/dynamic/s4l-ui:3.2.178' due to 1 validation error for ServiceMetaDataDBCreate
icon
  Input should be a valid string [type=string_type, input_value=HttpUrl('https://github.c...s/s4l/S4L.png?raw=true'), input_type=HttpUrl]
    For further information visit https://errors.pydantic.dev/2.10/v/string_type

The icon filed is an HttpUrl object and will not be saved in the DB as such. We need to convert it to a str.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Mar 10, 2025
@GitHK GitHK marked this pull request as ready for review March 10, 2025 10:37
@GitHK GitHK added this to the The Awakening milestone Mar 10, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! nice catch!

@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (30a4d87) to head (56723e0).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (30a4d87) and HEAD (56723e0). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (30a4d87) HEAD (56723e0)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7331       +/-   ##
===========================================
- Coverage   87.41%   68.86%   -18.55%     
===========================================
  Files        1693      707      -986     
  Lines       65873    33217    -32656     
  Branches     1121      168      -953     
===========================================
- Hits        57580    22875    -34705     
- Misses       7973    10284     +2311     
+ Partials      320       58      -262     
Flag Coverage Δ
integrationtests 65.38% <ø> (-0.01%) ⬇️
unittests 92.12% <100.00%> (+5.55%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog 92.12% <100.00%> (+0.01%) ⬆️
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.54% <ø> (-12.76%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.10% <ø> (-0.98%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.38% <ø> (-26.44%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a4d87...56723e0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK
Copy link
Contributor Author

GitHK commented Mar 10, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 615bd69

@GitHK GitHK added t:maintenance Some planned maintenance work 🤖-automerge marks PR as ready to be merged for Mergify labels Mar 10, 2025
@sonarqubecloud
Copy link

@mergify mergify bot merged commit 615bd69 into ITISFoundation:master Mar 10, 2025
59 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants