-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 fixed issue with catalog and the icon field #7331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fixed issue with catalog and the icon field #7331
Conversation
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx! nice catch!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7331 +/- ##
===========================================
- Coverage 87.41% 68.86% -18.55%
===========================================
Files 1693 707 -986
Lines 65873 33217 -32656
Branches 1121 168 -953
===========================================
- Hits 57580 22875 -34705
- Misses 7973 10284 +2311
+ Partials 320 58 -262
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 615bd69 |
|
Co-authored-by: Andrei Neagu <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>



What do these changes do?
Fixes the following issue
The icon filed is an
HttpUrlobject and will not be saved in the DB as such. We need to convert it to astr.Related issue/s
How to test
Dev-ops checklist