🐛 allows mergify to merge PRs #7332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
approved these changes
Mar 10, 2025
|
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The extra checks that I have added were not helpful at all. Depending on the PR, some checks did not run.
These checks were not useful. Mergify already keeps into consideration the GitHub branch protection rules. This was pointed out by SAN.
You can see here the details about the PR that's waiting on change which never pass https://dashboard.mergify.com/queues/status?repository=osparc-simcore&login=ITISFoundation&branch=master&queues=default&pull=7316
NOTE: this requires force merging.
Related issue/s
How to test
Dev-ops checklist