Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 11, 2025

What do these changes do?

When creating a hotfix release, the release notes url will automatically point to something like v.X.Y.1 we don't want any number different that 0 in the patch. This way we avoid duplicating the manually curated release notes.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Mar 11, 2025
@GitHK GitHK added this to the The Awakening milestone Mar 11, 2025
@GitHK GitHK added the t:maintenance Some planned maintenance work label Mar 11, 2025
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.11%. Comparing base (2ff240c) to head (3d1499e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7339      +/-   ##
==========================================
- Coverage   87.34%   84.11%   -3.24%     
==========================================
  Files        1704      659    -1045     
  Lines       66205    31563   -34642     
  Branches     1124      168     -956     
==========================================
- Hits        57828    26548   -31280     
+ Misses       8057     4957    -3100     
+ Partials      320       58     -262     
Flag Coverage Δ
integrationtests 65.36% <33.33%> (+0.02%) ⬆️
unittests 87.25% <100.00%> (+0.73%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.69% <ø> (-12.59%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.10% <ø> (-0.98%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.80% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff240c...3d1499e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK marked this pull request as ready for review March 11, 2025 12:49
@GitHK GitHK requested a review from giancarloromeo March 11, 2025 13:00
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@GitHK
Copy link
Contributor Author

GitHK commented Mar 11, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2025

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = deploy to dockerhub
        • check-skipped = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-neutral = unit-tests
        • check-skipped = unit-tests
        • check-success = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-neutral = integration-tests
        • check-skipped = integration-tests
        • check-success = integration-tests

@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 11, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Left a couple of tips and suggestions to make it more maintainable.

@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@GitHK
Copy link
Contributor Author

GitHK commented Mar 13, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2025

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2025

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@sonarqubecloud
Copy link

@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@GitHK
Copy link
Contributor Author

GitHK commented Mar 13, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2025

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 189df7a

@mergify mergify bot merged commit 189df7a into ITISFoundation:master Mar 13, 2025
141 of 148 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

patch version in release url should always be 0

5 participants