Skip to content

🎨 [Frontend] Show default product thumbnail if resource's thumbnail is invalid #7341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
odeimaiz merged 13 commits into from
Mar 12, 2025
Merged

🎨 [Frontend] Show default product thumbnail if resource's thumbnail is invalid #7341

odeimaiz merged 13 commits into from
Mar 12, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 11, 2025 •
edited
Loading

What do these changes do?

requested by @matusdrobuliak66

When users pick URLs to set their study thumbnails, the links might eventually get broken. In this PR when an invalid thumbnail is found, it gets replaced by the default product thumbnail (same as a null thumbnail).

Before:
Before

After:
After

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Mar 11, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Mar 11, 2025
@odeimaiz odeimaiz added this to the The Awakening milestone Mar 11, 2025
@odeimaiz odeimaiz marked this pull request as ready for review March 11, 2025 14:51
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Show default product thumbnail if resource's thumbnail doesn't exist 🎨 [Frontend] Show default product thumbnail if resource's thumbnail is invalid Mar 11, 2025
sanderegg
sanderegg reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, but would it not make sense to have an indication the link was broken somehow?

@odeimaiz
Copy link
Member Author

odeimaiz commented Mar 11, 2025 •
edited
Loading

cool, but would it not make sense to have an indication the link was broken somehow?

We can now fallback to any other image. What do you suggest?

@odeimaiz odeimaiz enabled auto-merge (squash) March 12, 2025 12:49
@odeimaiz odeimaiz disabled auto-merge March 12, 2025 12:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 12, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz
Copy link
Member Author

odeimaiz commented Mar 12, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-22.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-22.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-22.04)
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 12, 2025
@odeimaiz odeimaiz enabled auto-merge (squash) March 12, 2025 13:46
@odeimaiz odeimaiz merged commit c8fc64e into ITISFoundation:master Mar 12, 2025
106 of 108 checks passed
@odeimaiz odeimaiz deleted the enh/fallback-thumbnail branch March 12, 2025 13:57
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@odeimaiz @mrnicegyu11
🎨 [Frontend] Show default product thumbnail if resource's thumbnail i…
dc9df2c 
…s invalid (ITISFoundation#7341)
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanderegg sanderegg sanderegg left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

5 participants

@odeimaiz @giancarloromeo @GitHK @pcrespov @sanderegg