Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 11, 2025

What do these changes do?

This PR makes use of transaction helpers created by @pcrespov.

async with transaction_context

async with pass_or_acquire_connection

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Mar 11, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 11, 2025
@sanderegg sanderegg self-assigned this Mar 11, 2025
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 78.00000% with 66 lines in your changes missing coverage. Please review.

Project coverage is 88.91%. Comparing base (189df7a) to head (45cd7bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7343      +/-   ##
==========================================
+ Coverage   87.34%   88.91%   +1.56%     
==========================================
  Files        1704     1447     -257     
  Lines       66210    57461    -8749     
  Branches     1124      538     -586     
==========================================
- Hits        57833    51091    -6742     
+ Misses       8057     6220    -1837     
+ Partials      320      150     -170     
Flag Coverage Δ
integrationtests 65.31% <33.33%> (-0.01%) ⬇️
unittests 87.98% <78.00%> (+1.46%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.72% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.21% <ø> (ø)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.12% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.59% <ø> (-0.10%) ⬇️
director_v2 91.30% <ø> (+0.02%) ⬆️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.07% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <100.00%> (+0.01%) ⬆️
storage 82.40% <78.30%> (-3.05%) ⬇️
webclient ∅ <ø> (∅)
webserver 85.80% <33.33%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189df7a...45cd7bc. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg marked this pull request as ready for review March 11, 2025 21:12
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx so much!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks a lot. We might have a conflicts with my async jobs PR. But I think you should merge this one first.

@sanderegg sanderegg force-pushed the storage/use-transactions-helpers branch 2 times, most recently from f2f9c07 to 1407d25 Compare March 13, 2025 07:38
@sanderegg sanderegg force-pushed the storage/use-transactions-helpers branch from 1407d25 to 45cd7bc Compare March 13, 2025 08:46
@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 13, 2025
@sonarqubecloud
Copy link

@sanderegg sanderegg merged commit c1e8fea into ITISFoundation:master Mar 13, 2025
87 of 91 checks passed
@sanderegg sanderegg deleted the storage/use-transactions-helpers branch March 13, 2025 09:00
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:storage issue related to storage service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage: use the transaction context

5 participants