-
Notifications
You must be signed in to change notification settings - Fork 32
♻️Storage: use transactions helpers #7343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Storage: use transactions helpers #7343
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7343 +/- ##
==========================================
+ Coverage 87.34% 88.91% +1.56%
==========================================
Files 1704 1447 -257
Lines 66210 57461 -8749
Branches 1124 538 -586
==========================================
- Hits 57833 51091 -6742
+ Misses 8057 6220 -1837
+ Partials 320 150 -170
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx so much!
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this
bisgaard-itis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks a lot. We might have a conflicts with my async jobs PR. But I think you should merge this one first.
services/storage/src/simcore_service_storage/modules/db/file_meta_data.py
Show resolved
Hide resolved
services/storage/src/simcore_service_storage/modules/db/file_meta_data.py
Show resolved
Hide resolved
services/storage/src/simcore_service_storage/modules/db/file_meta_data.py
Show resolved
Hide resolved
f2f9c07 to
1407d25
Compare
1407d25 to
45cd7bc
Compare
|
Co-authored-by: Pedro Crespo-Valero <[email protected]>



What do these changes do?
This PR makes use of transaction helpers created by @pcrespov.
Related issue/s
How to test
Dev-ops checklist