Skip to content

🐛 Permission changes in dynamic-sidecar are always executed when closing a service #7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2025
Merged

🐛 Permission changes in dynamic-sidecar are always executed when closing a service #7372

merged 4 commits into from
Mar 18, 2025

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 17, 2025 •
edited
Loading

What do these changes do?

In case of errors during container removal, the permission change would have never been executed.

This fix ensures that the permission change block of code is now always executed.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Mar 17, 2025
@GitHK GitHK added the a:dynamic-sidecar dynamic-sidecar service label Mar 17, 2025
@GitHK GitHK added this to the The Awakening milestone Mar 17, 2025
@GitHK GitHK changed the title 🐛 Fixed edge case with permissions change 🐛 Permission changes in dynamic-sidecar are always executed when closing a service Mar 17, 2025
@codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (5aed474) to head (50aeab9).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5aed474) and HEAD (50aeab9). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (5aed474) HEAD (50aeab9)
unittests 30 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7372       +/-   ##
===========================================
- Coverage   87.28%   67.59%   -19.69%     
===========================================
  Files        1709      659     -1050     
  Lines       66325    31579    -34746     
  Branches     1124      168      -956     
===========================================
- Hits        57892    21347    -36545     
- Misses       8113    10174     +2061     
+ Partials      320       58      -262
Flag Coverage Δ
integrationtests 65.28% <0.00%> (-0.04%) ⬇️
unittests 89.18% <100.00%> (+2.73%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.52% <ø> (-12.78%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 90.11% <100.00%> (+0.03%) ⬆️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.25% <ø> (-26.55%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aed474...50aeab9. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK marked this pull request as ready for review March 18, 2025 06:58
@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 18, 2025
@GitHK
Copy link
Contributor Author

GitHK commented Mar 18, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = deploy to dockerhub
        • check-skipped = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-neutral = integration-tests
        • check-skipped = integration-tests
        • check-success = integration-tests

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 18, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GitHK
Copy link
Contributor Author

GitHK commented Mar 18, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-22.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-22.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-22.04)
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests

@sanderegg sanderegg merged commit 45ae7a5 into ITISFoundation:master Mar 18, 2025
50 checks passed
sanderegg pushed a commit that referenced this pull request Mar 18, 2025
@GitHK @mergify @sanderegg
🐛 Permission changes in dynamic-sidecar are always executed when clos…
5835cc2 
…ing a service (#7372)

Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@sanderegg sanderegg mentioned this pull request Mar 18, 2025
Closed
13 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@GitHK @mergify @mrnicegyu11
🐛 Permission changes in dynamic-sidecar are always executed when clos…
60b8d6e 
…ing a service (ITISFoundation#7372)

Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@GitHK GitHK

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:dynamic-sidecar dynamic-sidecar service

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

5 participants

@GitHK @giancarloromeo @pcrespov @sanderegg @bisgaard-itis