Skip to content

🐛 Permission changes in dynamic-sidecar are always executed when closing a service #7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2025
Merged

🐛 Permission changes in dynamic-sidecar are always executed when closing a service #7372

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e447ca
fixed issue
Mar 17, 2025
7a81f31
Merge branch 'master' into pr-osparc-refix-permissions-when-saving
mergify[bot] Mar 18, 2025
52c0592
Merge branch 'master' into pr-osparc-refix-permissions-when-saving
mergify[bot] Mar 18, 2025
50aeab9
Merge branch 'master' into pr-osparc-refix-permissions-when-saving
GitHK Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,9 @@ async def _send_resource_tracking_stop(platform_status: SimcorePlatformStatus):
# NOTE: https://github.com/ITISFoundation/osparc-simcore/issues/4952
await _send_resource_tracking_stop(SimcorePlatformStatus.OK)
raise

await ensure_read_permissions_on_user_service_data(mounted_volumes)
finally:
with log_context(_logger, logging.INFO, "ensure read permissions"):
await ensure_read_permissions_on_user_service_data(mounted_volumes)

await _send_resource_tracking_stop(SimcorePlatformStatus.OK)

Expand Down
Loading