Skip to content

⚗️Director-v0: Disable keep-alive connections #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2025
Merged

⚗️Director-v0: Disable keep-alive connections #7405

merged 3 commits into from
Mar 21, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 21, 2025 •
edited
Loading

What do these changes do?

After observing the registry is oddly loaded, we try to disable the Keep-alive connections in the httpx client. This way load-balancing via docker swarm shall not be impaired.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:director issue related with the director service label Mar 21, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 21, 2025
@sanderegg sanderegg requested a review from YuryHrytsuk March 21, 2025 10:04
@sanderegg sanderegg self-assigned this Mar 21, 2025
@YuryHrytsuk YuryHrytsuk mentioned this pull request Mar 21, 2025
Closed
7 tasks
YuryHrytsuk
YuryHrytsuk approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Mar 21, 2025
@codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.08%. Comparing base (85e24e8) to head (f9f60bd).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7405      +/-   ##
==========================================
- Coverage   87.31%   87.08%   -0.23%     
==========================================
  Files        1712     1343     -369     
  Lines       66429    56024   -10405     
  Branches     1125      578     -547     
==========================================
- Hits        58004    48790    -9214     
+ Misses       8105     7049    -1056     
+ Partials      320      185     -135
Flag Coverage Δ
integrationtests 65.28% <ø> (-0.03%) ⬇️
unittests 86.09% <50.00%> (-0.39%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.24% <0.00%> (ø)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.61% <100.00%> (+0.02%) ⬆️
director_v2 91.30% <ø> (+0.02%) ⬆️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (ø)
storage 84.52% <ø> (+0.03%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.82% <ø> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e24e8...f9f60bd. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg requested a review from odeimaiz March 21, 2025 10:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 21, 2025
@sanderegg sanderegg requested a review from GitHK March 21, 2025 10:31
@sanderegg
Copy link
Member Author

sanderegg commented Mar 21, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8944b1f

odeimaiz
odeimaiz approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mergify mergify bot merged commit 8944b1f into ITISFoundation:master Mar 21, 2025
94 of 95 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@sanderegg @mrnicegyu11
⚗️Director-v0: Disable keep-alive connections (ITISFoundation#7405)
23a1ecf
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:director issue related with the director service t:maintenance Some planned maintenance work

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

5 participants

@sanderegg @GitHK @pcrespov @odeimaiz @YuryHrytsuk