♻️ webserver: Refactor login domain for CSR compliance and future confirmation logic #7417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
force-pushed
the
is40/prepare-confirmation-servie
branch
from
dda5c04 to
03c8cfc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7417 +/- ##
==========================================
+ Coverage 87.37% 87.45% +0.07%
==========================================
Files 1715 1717 +2
Lines 66613 66606 -7
Branches 1132 1132
==========================================
+ Hits 58205 58251 +46
+ Misses 8087 8034 -53
Partials 321 321
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pcrespov
force-pushed
the
is40/prepare-confirmation-servie
branch
2 times, most recently
from
d82ee28 to
c1acfa7
Compare
pcrespov
added
the
a:webserver
pcrespov
changed the title
pcrespov
requested review from
GitHK,
matusdrobuliak66 and
sanderegg
as code owners
pcrespov
force-pushed
the
is40/prepare-confirmation-servie
branch
from
dbe17d7 to
54904a5
Compare
giancarloromeo
approved these changes
Mar 26, 2025
sanderegg
approved these changes
Mar 26, 2025
services/web/server/src/simcore_service_webserver/login/_controller/rest/twofa.py
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Refactored the old
logindomain to align with CSR layer requirements and in preparation for extending confirmation logic for sharing operations (ITISFoundation/private-issues#40).Confirmation Logic Overview
The confirmation logic is a mechanism for securely executing deferred actions via confirmation tokens. Each token, stored in the database, includes a secret code (
code), an associated function (action), and relevant parameters (data).When a user accesses a link containing the secret code, a designated GET entrypoint validates the token and triggers the corresponding action, using both the stored parameters and any additional context provided at runtime. Once executed, the confirmation entry is deleted.
This mechanism will be used to confirm sharing operations between users. For example, User A shares a project with User B and sends a confirmation link. When User B clicks the link, the system validates and executes the action, completing the sharing confirmation process.
Changes
Related issue/s
share_projectoperation (dev) and updates notifications-library #7431How to test
Dev-ops
None