Skip to content

🎨 Remove TaskStatus consistency check #7444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

🎨 Remove TaskStatus consistency check #7444

wants to merge 4 commits into from

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Mar 28, 2025 •
edited
Loading

What do these changes do?

  • Remove TaskStatus consistency check as it has caused a lot of issues when debugging storage in the last couple of days. It seems unnecessary.
  • Consistence should instead be ensured directly within the task by using ProgressBarData

Related issue/s

How to test

Dev-ops checklist

FYI @sanderegg @giancarloromeo

@bisgaard-itis bisgaard-itis self-assigned this Mar 28, 2025
@bisgaard-itis bisgaard-itis added the t:enhancement Improvement or request on an existing feature label Mar 28, 2025
@bisgaard-itis bisgaard-itis added this to the The Awakening milestone Mar 28, 2025
@codecov
Copy link

codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (7dd5842) to head (7f5a27f).
Report is 14 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (7dd5842) and HEAD (7f5a27f). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (7dd5842) HEAD (7f5a27f)
unittests 30 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7444       +/-   ##
===========================================
- Coverage   87.41%   68.88%   -18.53%     
===========================================
  Files        1729      735      -994     
  Lines       66864    34418    -32446     
  Branches     1133      168      -965     
===========================================
- Hits        58449    23709    -34740     
- Misses       8094    10651     +2557     
+ Partials      321       58      -263
Flag Coverage Δ
integrationtests 65.20% <ø> (+0.02%) ⬆️
unittests 87.13% <100.00%> (+0.53%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.51% <ø> (-12.79%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 87.13% <100.00%> (+0.03%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.12% <ø> (-26.74%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd5842...7f5a27f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pcrespov
pcrespov approved these changes Mar 28, 2025
View reviewed changes
sanderegg
sanderegg approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bisgaard-itis
Copy link
Contributor Author

bisgaard-itis commented Mar 31, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2025 •
edited
Loading

queue

☑️ Nothing to do

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • label=🤖-automerge
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bisgaard-itis
Copy link
Contributor Author

bisgaard-itis commented Apr 7, 2025

This was superseded here: #7468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

Assignees

@bisgaard-itis bisgaard-itis

Labels

t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

5 participants

@bisgaard-itis @giancarloromeo @GitHK @pcrespov @sanderegg