Skip to content

🎨 Program jobs: Pass metadata and return display version #7562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 29, 2025
Merged

🎨 Program jobs: Pass metadata and return display version #7562

merged 14 commits into from
Apr 29, 2025

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Apr 23, 2025 •
edited
Loading

What do these changes do?

ReDoc

  • Allow user to specify name and description when creating a program job via the api-server.
    • N.B. @pcrespov that one important consequence of this is that the job name is no longer an identifier. That should be OK though because we now have our beautiful projects_to_jobs table.
  • Propagate a Program's display version to the api-server.

Related issue/s

How to test

Dev-ops checklist

@codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.58%. Comparing base (7ea3b05) to head (ee972c1).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (7ea3b05) and HEAD (ee972c1). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (7ea3b05) HEAD (ee972c1)
unittests 31 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7562       +/-   ##
===========================================
- Coverage   87.69%   69.58%   -18.12%     
===========================================
  Files        1774      779      -995     
  Lines       68368    35529    -32839     
  Branches     1125      170      -955     
===========================================
- Hits        59956    24722    -35234     
- Misses       8105    10749     +2644     
+ Partials      307       58      -249
Flag Coverage Δ
integrationtests 65.15% <ø> (+0.07%) ⬆️
unittests 91.46% <100.00%> (+4.56%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.35% <ø> (-8.13%) ⬇️
agent ∅ <ø> (∅)
api_server 91.46% <100.00%> (+0.06%) ⬆️
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.53% <ø> (-12.82%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.06% <ø> (-1.10%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.15% <ø> (-26.95%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea3b05...ee972c1. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis bisgaard-itis marked this pull request as ready for review April 23, 2025 09:21
@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner April 23, 2025 09:21
@bisgaard-itis bisgaard-itis self-assigned this Apr 23, 2025
@bisgaard-itis bisgaard-itis added the a:apiserver api-server service label Apr 23, 2025
@bisgaard-itis bisgaard-itis added this to the Pauwel Kwak milestone Apr 23, 2025
pcrespov
pcrespov approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

pcrespov
pcrespov reviewed Apr 24, 2025
View reviewed changes
matusdrobuliak66
matusdrobuliak66 approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sanderegg
sanderegg approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bisgaard-itis bisgaard-itis requested a review from pcrespov April 29, 2025 07:54
@bisgaard-itis bisgaard-itis enabled auto-merge (squash) April 29, 2025 07:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 29, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bisgaard-itis bisgaard-itis merged commit 2f98a0b into ITISFoundation:master Apr 29, 2025
92 of 95 checks passed
@bisgaard-itis bisgaard-itis deleted the 49-46-pass-metadata-and-return-display-version branch April 29, 2025 08:45
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@mguidon mguidon Awaiting requested review from mguidon

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

Assignees

@bisgaard-itis bisgaard-itis

Labels

a:apiserver api-server service

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

4 participants

@bisgaard-itis @pcrespov @sanderegg @matusdrobuliak66