-
Notifications
You must be signed in to change notification settings - Fork 32
✨ api-server: listing of all solver jobs #7566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ api-server: listing of all solver jobs #7566
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7566 +/- ##
===========================================
+ Coverage 73.68% 87.69% +14.01%
===========================================
Files 1086 1744 +658
Lines 43753 67676 +23923
Branches 534 1135 +601
===========================================
+ Hits 32238 59351 +27113
+ Misses 11372 8011 -3361
- Partials 143 314 +171
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
0b7e00d to
902c768
Compare
747001a to
751fea1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
…ions and examples
services/api-server/src/simcore_service_api_server/_service_solvers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs_getters.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again. |
|



What do these changes do?
This PR exposes in the public API, listing of all solver jobs (
list_all_solver_jobs) as dev-featureController-layer (public-api):
/-/releases/-/jobsto list all solver jobs with pagination (but not shown in OAS sinceinclude_in_schema=False)Service-layer
list_jobsmethod in theSolverServiceclass to fetch solver jobs with pagination and filtering by resource name prefixSolverServicewith underlying webserver's rpc clientapi/dependencies.Dependscreates a relation between service-layer and controller, therefore it should not be in the service-layer.Schema and Validation Updates
creation_atfield tocreated_atin theProjectJobRpcGetmodel and updated corresponding schema examples for consistency.trim_string_beforeto enforce string length limits during validation. (packages/models-library/src/models_library/utils/common_validators.py)Related issue/s
GET /v0/solvers/-/releases/-/jobs/page#7399How to test
Dev-ops
None