-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Replaces built-in JSON serialization with common_library utilities #7569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Replaces built-in JSON serialization with common_library utilities #7569
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7569 +/- ##
==========================================
- Coverage 87.63% 87.55% -0.08%
==========================================
Files 1759 1698 -61
Lines 68188 66440 -1748
Branches 1125 1037 -88
==========================================
- Hits 59755 58174 -1581
+ Misses 8124 7977 -147
+ Partials 309 289 -20
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
abd3323 to
49f71b1
Compare
724236a to
892456b
Compare
packages/models-library/src/models_library/utils/change_case.py
Outdated
Show resolved
Hide resolved
|
@mergify queue |
🟠 Waiting for conditions to match
|
ed09b5e to
566452d
Compare
0f9d431 to
b53900d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…ross director and registry_proxy modules
…d Pydantic methods
b53900d to
c9fc66a
Compare
|



What do these changes do?
Use the
json_loadsfunction fromcommon_library.json_serializationinstead of the built-injson.dumpsandjson.loadsfor serialization and deserialization. These functions are built on top oforjsonand are significantly more reliable. Avoid usingjson.dumpsandjson.loads.NOTE: json_dumps by default has no spaces compared to `json.dumps"
When working with Pydantic models, use their built-in methods for serialization/deserialization—for example,
model.model_dump_json()—instead of external utilities.This PR updates this practice across all the repo code-base (avoided scripts and tests)
Related issue/s
Maintenance
How to test
Dev-ops