Skip to content

🎨 [Frontend] Enh: Converstations #7571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Apr 24, 2025
Merged

🎨 [Frontend] Enh: Converstations #7571

merged 27 commits into from
Apr 24, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 23, 2025 •
edited
Loading

What do these changes do?

This PR refactors a bit the Comments/Conversations widget and it also makes the Conversations feature more visible to access it from within the Study.

It also enhances the Note creation by proposing to share the study with the note's recipient user if the it is for a user that has no access to the Study.

Bonus: fix the /jobs request when there are more than 50 jobs (reported by @mguidon )

Chat

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 23, 2025
@odeimaiz odeimaiz marked this pull request as ready for review April 24, 2025 14:38
@odeimaiz odeimaiz added this to the Pauwel Kwak milestone Apr 24, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Apr 24, 2025
@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 24, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8c0a500

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sanderegg
sanderegg reviewed Apr 24, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mguidon
mguidon approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks

@mergify mergify bot merged commit 8c0a500 into ITISFoundation:master Apr 24, 2025
59 checks passed
@odeimaiz odeimaiz deleted the enh/converstations branch April 28, 2025 05:05
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanderegg sanderegg sanderegg left review comments

@mguidon mguidon mguidon approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@alexpargon alexpargon Awaiting requested review from alexpargon

@pcrespov pcrespov Awaiting requested review from pcrespov

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@odeimaiz odeimaiz

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

4 participants

@odeimaiz @mguidon @sanderegg @matusdrobuliak66