Skip to content

⬆️Maintenance: unblock boto3 #7572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

⬆️Maintenance: unblock boto3 #7572

merged 3 commits into from
Apr 24, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 24, 2025 •
edited by GitHK
Loading

🚨🚨🚨: Check CEPH S3 compatibility when deleting a file

The issue arising in tests was coming from Minio: minio/minio#20845, updating the minio to the latest version RELEASE.2025-04-22T22-12-26Z solves the problem

Highlights on updated libraries (only updated libraries are included)

  • #packages before ~ 10
  • #packages after ~ 6
# name before after upgrade count packages
1 aioboto3 13.3.0, 13.1.0, 13.2.0 14.1.0 MAJOR 10 agent🧪
autoscaling⬆️
aws-library🧪
clusters-keeper⬆️
director-v2🧪
dynamic-sidecar🧪
efs-guardian⬆️
resource-usage-tracker⬆️
simcore-sdk🧪
storage⬆️
2 aiobotocore 2.16.0, 2.15.2, 2.13.1 2.21.1 minor 11 agent🧪
autoscaling⬆️
aws-library🧪
clusters-keeper⬆️
dask-sidecar⬆️
director-v2🧪
dynamic-sidecar🧪
efs-guardian⬆️
resource-usage-tracker⬆️
simcore-sdk🧪
storage⬆️
3 aiopg 1.4.0 🗑️ removed 1 swarm-deploy🧪
4 async-timeout 4.0.3 🗑️ removed 1 swarm-deploy🧪
5 boto3 1.34.131, 1.34.75, 1.35.81, 1.35.99, 1.35.36 1.37.1,1.38.1 minor 19 agent🧪
api-server🧪
autoscaling⬆️🧪
aws-library🧪🧪
clusters-keeper⬆️🧪
dask-sidecar🧪
datcore-adapter⬆️
director-v2🧪
dynamic-sidecar🧪
efs-guardian⬆️🧪
resource-usage-tracker⬆️🧪
simcore-sdk🧪
storage⬆️🧪
6 botocore 1.37.4, 1.34.131, 1.34.75, 1.35.81, 1.35.99, 1.35.36 1.37.1,1.38.1 minor 21 agent🧪
api-server🧪
autoscaling⬆️🧪
aws-library🧪🧪
clusters-keeper⬆️🧪
dask-sidecar⬆️🧪
datcore-adapter⬆️
director-v2🧪
dynamic-sidecar🧪
efs-guardian⬆️🧪
resource-usage-tracker⬆️🧪
service-library🧪
simcore-sdk🧪
storage⬆️🧪
7 moto 5.1.1 5.1.4 9 agent🧪
autoscaling🧪
aws-library🧪
clusters-keeper🧪
dask-sidecar🧪
efs-guardian🧪
resource-usage-tracker🧪
simcore-sdk🧪
storage🧪
8 opentelemetry-instrumentation-aiopg 0.49, 0.51 🗑️ removed 3 api-server⬆️
director-v2⬆️
swarm-deploy🧪
9 opentelemetry-instrumentation-dbapi 0.49, 0.51 🗑️ removed 3 api-server⬆️
director-v2⬆️
swarm-deploy🧪
10 s3transfer 0.10.4, 0.10.1, 0.10.3 0.12.0,0.11.3 minor 19 agent🧪
api-server🧪
autoscaling⬆️🧪
aws-library🧪🧪
clusters-keeper⬆️🧪
dask-sidecar🧪
datcore-adapter⬆️
director-v2🧪
dynamic-sidecar🧪
efs-guardian⬆️🧪
resource-usage-tracker⬆️🧪
simcore-sdk🧪
storage⬆️🧪

Legend:

  • ⬆️ base dependency (only services because packages are floating)
  • 🧪 test dependency
  • 🔧 tool dependency

@sanderegg sanderegg self-assigned this Apr 24, 2025
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Apr 24, 2025
@sanderegg sanderegg added this to the Pauwel Kwak milestone Apr 24, 2025
@codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (3880aff) to head (247d772).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7572      +/-   ##
==========================================
+ Coverage   87.63%   87.66%   +0.03%     
==========================================
  Files        1759     1752       -7     
  Lines       68188    67998     -190     
  Branches     1125     1125              
==========================================
- Hits        59756    59612     -144     
+ Misses       8123     8077      -46     
  Partials      309      309
Flag Coverage Δ
integrationtests 65.09% <ø> (+<0.01%) ⬆️
unittests 86.85% <ø> (+0.02%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.91% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.70% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.18% <ø> (ø)
pkg_service_integration 69.98% <ø> (ø)
pkg_service_library 72.92% <ø> (ø)
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.67% <ø> (+0.23%) ⬆️
agent 96.46% <ø> (ø)
api_server 91.28% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.65% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.78% <ø> (ø)
director_v2 91.39% <ø> (+0.02%) ⬆️
dynamic_scheduler 97.40% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (-0.11%) ⬇️
storage 87.58% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.02% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3880aff...247d772. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg changed the title Maintenance/unblock boto3 ⬆️Maintenance/unblock boto3 🚨🚨🚨🚨 Apr 24, 2025
@sanderegg sanderegg marked this pull request as ready for review April 24, 2025 08:49
@sanderegg sanderegg changed the title ⬆️Maintenance/unblock boto3 🚨🚨🚨🚨 ⬆️Maintenance: unblock boto3 🚨🚨🚨🚨 Apr 24, 2025
matusdrobuliak66
matusdrobuliak66 approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

GitHK
GitHK approved these changes Apr 24, 2025
View reviewed changes
@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 24, 2025
@sanderegg
Copy link
Member Author

sanderegg commented Apr 24, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sanderegg sanderegg merged commit 2d68a47 into ITISFoundation:master Apr 24, 2025
93 checks passed
@sanderegg sanderegg deleted the maintenance/unblock-boto3 branch April 24, 2025 09:46
@sanderegg sanderegg changed the title ⬆️Maintenance: unblock boto3 🚨🚨🚨🚨 ⬆️Maintenance: unblock boto3 Apr 25, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis bisgaard-itis is a code owner

Assignees

@sanderegg sanderegg

Labels

🤖-automerge marks PR as ready to be merged for Mergify t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

boto3 pinned due to delete object checksum issue

4 participants

@sanderegg @giancarloromeo @GitHK @matusdrobuliak66