Skip to content

🎨E2E: when service legacy there is no need to wait for the running events #7579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

🎨E2E: when service legacy there is no need to wait for the running events #7579

merged 1 commit into from
Apr 25, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 25, 2025 •
edited
Loading

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added t:maintenance Some planned maintenance work e2e Bugs found by or related to the end-2-end testing labels Apr 25, 2025
@sanderegg sanderegg added this to the Pauwel Kwak milestone Apr 25, 2025
@sanderegg sanderegg self-assigned this Apr 25, 2025
@sanderegg sanderegg requested a review from pcrespov as a code owner April 25, 2025 06:52
@sanderegg sanderegg mentioned this pull request Apr 25, 2025
Closed
1 task
@codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.58%. Comparing base (1b6b386) to head (713933f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7579      +/-   ##
==========================================
- Coverage   87.67%   87.58%   -0.10%     
==========================================
  Files        1774     1767       -7     
  Lines       68437    68247     -190     
  Branches     1126     1126              
==========================================
- Hits        60005    59771     -234     
- Misses       8124     8168      +44     
  Partials      308      308
Flag Coverage Δ
integrationtests 53.38% <ø> (-11.73%) ⬇️
unittests 86.90% <ø> (+0.02%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.87% <ø> (ø)
pkg_dask_task_models_library 97.10% <ø> (ø)
pkg_models_library 92.72% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.18% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 72.95% <ø> (ø)
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.66% <ø> (+0.17%) ⬆️
agent 96.46% <ø> (ø)
api_server 91.27% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.80% <ø> (-0.10%) ⬇️
director_v2 91.34% <ø> (-0.05%) ⬇️
dynamic_scheduler 97.40% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.23% <ø> (+0.10%) ⬆️
storage 87.77% <ø> (+0.21%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.57% <ø> (-0.47%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6b386...713933f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg force-pushed the maintenance/playwright-improvements6 branch from d48a8dd to 144557e Compare April 25, 2025 11:41
@sanderegg sanderegg force-pushed the maintenance/playwright-improvements6 branch from 144557e to 713933f Compare April 25, 2025 12:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit 1d581a9 into ITISFoundation:master Apr 25, 2025
90 of 95 checks passed
@sanderegg sanderegg deleted the maintenance/playwright-improvements6 branch April 25, 2025 13:38
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

4 participants

@sanderegg @GitHK @pcrespov @matusdrobuliak66