Skip to content

🐛 [Frontend] Fix share service #7593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

🐛 [Frontend] Fix share service #7593

merged 1 commit into from
Apr 28, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 28, 2025 •
edited
Loading

What do these changes do?

reported by @mguidon (e2e test will follow)

ShareService

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 28, 2025
@odeimaiz odeimaiz added this to the Pauwel Kwak milestone Apr 28, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Apr 28, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 28, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz marked this pull request as ready for review April 28, 2025 05:53
sanderegg
sanderegg reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

mguidon
mguidon approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@odeimaiz odeimaiz merged commit c490124 into ITISFoundation:master Apr 28, 2025
58 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanderegg sanderegg sanderegg left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@mguidon mguidon mguidon approved these changes

@alexpargon alexpargon Awaiting requested review from alexpargon

@pcrespov pcrespov Awaiting requested review from pcrespov

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

Services cannot be shared through frontend

5 participants

@odeimaiz @giancarloromeo @GitHK @mguidon @sanderegg