🐛 [Frontend] Fix: Cached promises #7595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
odeimaiz
added
bug
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
pcrespov and
sanderegg
GitHK
approved these changes
Apr 28, 2025
matusdrobuliak66
approved these changes
Apr 28, 2025
giancarloromeo
approved these changes
Apr 28, 2025
pcrespov
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR fixes an issue that makes the e2e flaky and fast users on a slowish network could reproduce.
In order to avoid making duplicated
/service-metadatacalls to the backend, the frontend keeps a promises cache. This promises were resolved too late in the frontend's code, making those elements that were using the cached promise fail. This PR fixes this issue.Related issue/s
How to test
Dev-ops checklist