Skip to content

✨ Add lifespan handling to tracing instrumentation and instrument rabbitmq rpc clients #7642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
May 23, 2025
Merged

✨ Add lifespan handling to tracing instrumentation and instrument rabbitmq rpc clients #7642

merged 33 commits into from
May 23, 2025
+428 −129

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented May 6, 2025 •
edited
Loading

What do these changes do?

  • Add lifespan management to opentelemetry tracing instrumentation. The main reason for this is our testing where we need to ensure we disable the instrumentation after a test is done.
  • Instrument our rpc and rabbitmq clients.

Related issue/s

How to test

Dev-ops

@bisgaard-itis bisgaard-itis changed the title 7634 opentelemetry instrument rpc clients ✨ opentelemetry instrument rpc clients May 6, 2025
@codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.09091% with 63 lines in your changes missing coverage. Please review.

Project coverage is 87.20%. Comparing base (fa9d3a0) to head (f545694).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7642      +/-   ##
==========================================
- Coverage   87.37%   87.20%   -0.18%     
==========================================
  Files        1838     1448     -390     
  Lines       71336    60632   -10704     
  Branches     1202      663     -539     
==========================================
- Hits        62330    52874    -9456     
+ Misses       8676     7549    -1127     
+ Partials      330      209     -121
Flag Coverage Δ
integrationtests 64.29% <62.50%> (-0.01%) ⬇️
unittests 86.28% <59.09%> (-0.32%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.92% <ø> (ø)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 71.86% <52.00%> (-0.35%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.01% <ø> (-0.12%) ⬇️
agent 96.46% <66.66%> (ø)
api_server 91.58% <66.66%> (ø)
autoscaling 96.07% <66.66%> (ø)
catalog 92.29% <75.00%> (ø)
clusters_keeper 99.25% <75.00%> (ø)
dask_sidecar 91.67% <ø> (ø)
datcore_adapter 98.12% <75.00%> (ø)
director 76.78% <66.66%> (ø)
director_v2 91.02% <66.66%> (-0.03%) ⬇️
dynamic_scheduler 96.76% <83.33%> (ø)
dynamic_sidecar 90.18% <66.66%> (ø)
efs_guardian 89.79% <50.00%> (ø)
invitations 93.28% <66.66%> (ø)
payments 92.63% <66.66%> (ø)
resource_usage_tracker 89.02% <66.66%> (-0.17%) ⬇️
storage 87.56% <66.66%> (ø)
webclient ∅ <ø> (∅)
webserver 85.71% <100.00%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa9d3a0...f545694. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis bisgaard-itis self-assigned this May 6, 2025
@bisgaard-itis bisgaard-itis added this to the Bazinga! milestone May 6, 2025
@bisgaard-itis bisgaard-itis marked this pull request as ready for review May 6, 2025 12:48
@bisgaard-itis bisgaard-itis requested a review from mrnicegyu11 May 6, 2025 12:48
mrnicegyu11
mrnicegyu11 reviewed May 6, 2025
View reviewed changes
mrnicegyu11
mrnicegyu11 reviewed May 6, 2025
View reviewed changes
sanderegg
sanderegg reviewed May 7, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if I understand correctly you also updated all the open telemtry stuff?
maybe can you add the list of changes in the PR description and set the icons accordingly?

mrnicegyu11
mrnicegyu11 requested changes May 7, 2025
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as said please factor the removal of postgres autoinstrumentation into a seperate PR, thx very nice

@bisgaard-itis
Copy link
Contributor Author

bisgaard-itis commented May 7, 2025

I have reverted the removal of the postgress database instrumentation. Please also see my comment above concerning this.

mrnicegyu11
mrnicegyu11 approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

pcrespov
pcrespov approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@bisgaard-itis bisgaard-itis changed the title ✨ opentelemetry instrument rpc clients ✨ Add lifespan handling of tracing instrumentation and instrument rabbitmq rpc clients May 23, 2025
@bisgaard-itis bisgaard-itis changed the title ✨ Add lifespan handling of tracing instrumentation and instrument rabbitmq rpc clients ✨ Add lifespan handling to tracing instrumentation and instrument rabbitmq rpc clients May 23, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 23, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bisgaard-itis bisgaard-itis merged commit 94d07d3 into ITISFoundation:master May 23, 2025
94 of 95 checks passed
@bisgaard-itis bisgaard-itis deleted the 7634-opentelemetry-instrument-rpc-clients branch May 23, 2025 12:33
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

Assignees

@bisgaard-itis bisgaard-itis

Labels

None yet

Projects

None yet

Milestone

Bazinga!

Development

Successfully merging this pull request may close these issues.

Instrument RPC clients

6 participants

@bisgaard-itis @GitHK @mrnicegyu11 @pcrespov @sanderegg @matusdrobuliak66