Skip to content

🐛Dask-Sidecar: explicitely set expand flag to remove confusing error message #7645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

🐛Dask-Sidecar: explicitely set expand flag to remove confusing error message #7645

merged 1 commit into from
May 8, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented May 8, 2025

What do these changes do?

This flag should silence the wrongly shown error message:

ERROR: [2024-09-05 08:04:11,514/Dask Worker process (from Nanny)] [simcore_service_dask_sidecar.dask_utils:publish_logs(98)]  -  [sidecar] Task error:
[Errno %s not found. The URL contains glob characters: you maybe needed
to pass expand=True in fsspec.open() or the storage_options of 
your library. You can also set the config value 'open_expand'
before import, or fsspec.core.DEFAULT_EXPAND at runtime, to True.] https://s3.amazonaws.com/production-simcore/0cb0a922-6adf-11ef-a2bb-0242ac174682/69c7a296-f83f-4b61-abf1-a569b04f653a/input0.json?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIATHZO54NSLAMDH4NW/20240904/us-east-1/s3/aws4_request&X-Amz-Date=20240904T171209Z&X-Amz-Expires=43200&X-Amz-SignedHeaders=host&X-Amz-Signature=97d134030154638cedc3adf7e560af2ba75ef71c4ce42a52d562dd24f7c9b076

which is confusing

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Bazinga! milestone May 8, 2025
@sanderegg sanderegg self-assigned this May 8, 2025
@sanderegg sanderegg added bug buggy, it does not work as expected a:dask-service Any of the dask services: dask-scheduler/sidecar or worker labels May 8, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.68%. Comparing base (fb428dc) to head (825e6cc).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (fb428dc) and HEAD (825e6cc). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (fb428dc) HEAD (825e6cc)
unittests 31 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7645       +/-   ##
===========================================
- Coverage   87.72%   67.68%   -20.05%     
===========================================
  Files        1788      706     -1082     
  Lines       68979    33288    -35691     
  Branches     1134      170      -964     
===========================================
- Hits        60511    22530    -37981     
- Misses       8156    10700     +2544     
+ Partials      312       58      -254
Flag Coverage Δ
integrationtests 64.96% <ø> (+0.03%) ⬆️
unittests 91.37% <ø> (+4.43%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.53% <ø> (-7.95%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar 91.37% <ø> (ø)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.14% <ø> (-12.97%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.06% <ø> (-1.10%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.11% <ø> (-26.92%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb428dc...825e6cc. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg merged commit 0a9c2d0 into ITISFoundation:master May 8, 2025
90 of 92 checks passed
@sanderegg sanderegg deleted the bugfix/explicitely-set-no-expand branch May 8, 2025 07:54
@sanderegg sanderegg mentioned this pull request May 28, 2025
Open
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sanderegg sanderegg

Labels

a:dask-service Any of the dask services: dask-scheduler/sidecar or worker bug buggy, it does not work as expected

Projects

None yet

Milestone

Bazinga!

Development

Successfully merging this pull request may close these issues.

1 participant

@sanderegg