🎨 [Frontend] Enh: Lazy load templates #7647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
requested review from
GitHK,
Copilot,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the way templates are loaded by delaying their fetching until needed and converting the Templates store from a singleton to a static class. Key changes include:
- Modifying the Templates store to use static methods with caching and promise‐based fetching.
- Updating UI components (TemplatesList, TemplateBrowser, NewStudies, NewPlusMenu, etc.) to work asynchronously with the new Templates API.
- Minor adjustments in test files and other resource browsers to incorporate lazy loading and improved asynchronous handling.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/e2e/tests/startupCalls.js | Commented out tests for Tasks and Templates were adjusted. |
| services/static-webserver/client/source/class/osparc/study/Conversations.js | Returned the promise from the fetch call for addMessage. |
| services/static-webserver/client/source/class/osparc/store/Templates.js | Changed the class design from a singleton to a static class with promise‐based fetching and caching. |
| (Other UI components) | Updated calls to Templates methods to use the new static async API. |
Comments suppressed due to low confidence (3)
tests/e2e/tests/startupCalls.js:68
- [nitpick] There are tests for Tasks and Templates that have been commented out. If these tests are no longer needed, consider removing them or adding a clarifying comment so future maintainers understand the intent.
- /*
services/static-webserver/client/source/class/osparc/store/Templates.js:18
- Converting the Templates class from a singleton to a static class changes how 'this' is used inside its methods. Ensure that all static methods correctly reference and update class-level variables (such as __templates and __templatesPromisesCached) as intended in the framework.
qx.Class.define("osparc.store.Templates", { type: "static",
services/static-webserver/client/source/class/osparc/study/Conversations.js:93
- The added return statement now ensures the fetch promise is propagated; please confirm that all its callers are updated to handle the asynchronous result appropriately.
return osparc.data.Resources.fetch("conversations", "addMessage", params)
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 5a1666d |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
All templates were loaded at start up, adding some extra calls (
/templatesand their/services) that were not necessary, except for the TI products that do require the templates for the New Plans button.This PR improves that logic and should speed up the start up process and relieve the webserver a bit. This change will be more noticeable in those deployments that have many templates.
S4L:
osparc:
tip:
Related issue/s
How to test
Dev-ops