🎨 Adding filtering for template type + extend patching #7689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7689 +/- ##
==========================================
+ Coverage 87.57% 88.97% +1.39%
==========================================
Files 1804 1559 -245
Lines 70181 62206 -7975
Branches 1137 608 -529
==========================================
- Hits 61462 55347 -6115
+ Misses 8409 6696 -1713
+ Partials 310 163 -147
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
matusdrobuliak66
added
the
a:webserver
matusdrobuliak66
changed the title
matusdrobuliak66
requested review from
GitHK,
giancarloromeo,
pcrespov and
sanderegg
as code owners
GitHK
approved these changes
May 16, 2025
services/web/server/src/simcore_service_webserver/projects/_controller/projects_rest_schemas.py
Outdated
Show resolved
Hide resolved
pcrespov
approved these changes
May 16, 2025
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
Thx. Left some suggestions. Please consider them before merging.
services/web/server/src/simcore_service_webserver/projects/_controller/projects_rest_schemas.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_controller/projects_rest_schemas.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_projects_service.py
Show resolved
Hide resolved
...ces/web/server/tests/unit/with_dbs/02/test_projects_crud_handlers__list_with_query_params.py
Outdated
Show resolved
Hide resolved
...ces/web/server/tests/unit/with_dbs/02/test_projects_crud_handlers__list_with_query_params.py
Show resolved
Hide resolved
...ces/web/server/tests/unit/with_dbs/02/test_projects_crud_handlers__list_with_query_params.py
Show resolved
Hide resolved
...ces/web/server/tests/unit/with_dbs/02/test_projects_crud_handlers__list_with_query_params.py
Outdated
Show resolved
Hide resolved
...ces/web/server/tests/unit/with_dbs/02/test_projects_crud_handlers__list_with_query_params.py
Outdated
Show resolved
Hide resolved
matusdrobuliak66
added
the
🤖-automerge
|
matusdrobuliak66
merged commit 37d7a7d
into
ITISFoundation:master
94 of 95 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
osparc-simcore/services/web/server/tests/unit/with_dbs/02/test_projects_crud_handlers__list_with_query_params.pyDev-ops