Fix functions frontend by using schema_content instead of schema_dict 🐛🚑️ #7705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
approved these changes
May 20, 2025
|
Contributor
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 5c86393 |
pcrespov
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
There was a small inconsistency between the frontend function definition and the backend, introduced during changes in the functions API PR. It prevent the input/output schema's ending up in the db.
Also a small change in how default inputs are handled. Default inputs are only used when the parameter is not exposed by the user.
Also the function name is the 'title' field (in sync with other osparc objects).
How to test
Create a function in the frontend. Check in postgres if funcapi_functions table has the correct function with schema.
Dev-ops
No change ENV