✨ [Frontend] Pretty JSON objects #7710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a pretty-print feature for JSON objects in info buttons using the JsonFormatter library. Key changes include:
- Adding the unminified JsonFormatter library as a static resource.
- Refactoring the JsonTreeViewer and JsonFormatter wrappers for improved coding standards.
- Updating job info and dashboard components to integrate the new JSON formatting.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| json-formatter-2.5.23.js | Added vendor file with the JsonFormatter library |
| JsonTreeViewer.js | Refactored variable declarations to use const for improved code consistency |
| JsonFormatter.js | New qooxdoo wrapper for the JsonFormatter library |
| Info.js | Updated to use the new JSON Formatter; includes unreachable legacy code |
| Dashboard.js | Initialized the new JsonFormatter wrapper |
| CardBase.js | Improved filter ID logic by extracting common functionality |
Files not reviewed (2)
- services/static-webserver/client/source/resource/jsonFormatter/json-formatter-2.5.23.css: Language not supported
- services/static-webserver/client/source/resource/jsontreeviewer/jsonTree.css: Language not supported
services/static-webserver/client/source/class/osparc/jobs/Info.js
Outdated
Show resolved
Hide resolved
GitHK
approved these changes
May 21, 2025
…-simcore into feature/json-tree-viewer
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at e395992 |
matusdrobuliak66
approved these changes
May 21, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR prettifies the JSON Objects shown in the info buttons of the Runs and Tasks. If wanted, this could become the default Json viewer in osparc.
In order to prettify them the 3rd party JsonFormatter library was used.
Related issue/s
How to test
Dev-ops