Skip to content

🎨 web-server: Advertises state of WEBSERVER_FUNCTIONS so front-end can enable/disable this feature #7715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

🎨 web-server: Advertises state of WEBSERVER_FUNCTIONS so front-end can enable/disable this feature #7715

merged 2 commits into from
May 21, 2025

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented May 21, 2025 •
edited
Loading

What do these changes do?

Advertises state of WEBSERVER_FUNCTIONS so front-end can enable/disable this feature. Does some cleanup as well.

♻️ Changes to plugin handling:

  • Renamed _get_disabled_public_plugins to _get_disabled_advertised_plugins to better reflect its purpose of identifying plugins that are disabled from being advertised to the client. Added a clarifying docstring and updated the list of plugins to include WEBSERVER_FUNCTIONS.
  • Updated the to_client_statics method to use the newly renamed _get_disabled_advertised_plugins method, ensuring consistency across the codebase.

Related issue/s

How to test

Dev-ops

None

@pcrespov pcrespov self-assigned this May 21, 2025
@pcrespov pcrespov added this to the Bazinga! milestone May 21, 2025
@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs 🤖-automerge marks PR as ready to be merged for Mergify labels May 21, 2025
@pcrespov pcrespov requested review from odeimaiz and wvangeit May 21, 2025 10:34
@pcrespov pcrespov marked this pull request as ready for review May 21, 2025 10:34
@pcrespov
Copy link
Member Author

pcrespov commented May 21, 2025

@mergify queue

@pcrespov pcrespov enabled auto-merge (squash) May 21, 2025 10:34
@mergify
Copy link
Contributor

mergify bot commented May 21, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

odeimaiz
odeimaiz approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci

@codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.80%. Comparing base (7185458) to head (121e807).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7715      +/-   ##
==========================================
- Coverage   87.35%   83.80%   -3.56%     
==========================================
  Files        1839      701    -1138     
  Lines       71084    33132   -37952     
  Branches     1203      174    -1029     
==========================================
- Hits        62097    27766   -34331     
+ Misses       8659     5308    -3351     
+ Partials      328       58     -270
Flag Coverage Δ
integrationtests 64.39% <25.00%> (-0.01%) ⬇️
unittests 86.93% <100.00%> (+0.36%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.95% <ø> (-8.12%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.70% <ø> (-13.36%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.83% <ø> (-1.36%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.60% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7185458...121e807. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov disabled auto-merge May 21, 2025 11:30
@pcrespov pcrespov merged commit 1fa455a into ITISFoundation:master May 21, 2025
3 of 4 checks passed
@pcrespov pcrespov deleted the mai/show-functions-plugin-state branch May 21, 2025 11:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@wvangeit wvangeit Awaiting requested review from wvangeit

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

Assignees

@pcrespov pcrespov

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Bazinga!

Development

Successfully merging this pull request may close these issues.

4 participants

@pcrespov @GitHK @odeimaiz @matusdrobuliak66