✨ [Frontend] Allow users access not-running latest runs #7723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
…into feature/access-all-runs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7723 +/- ##
===========================================
- Coverage 87.19% 66.65% -20.54%
===========================================
Files 1786 707 -1079
Lines 69761 33299 -36462
Branches 1203 174 -1029
===========================================
- Hits 60827 22197 -38630
- Misses 8606 11044 +2438
+ Partials 328 58 -270
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
odeimaiz
requested review from
GitHK,
Copilot,
matusdrobuliak66,
mguidon,
pcrespov and
sanderegg
GitHK
approved these changes
May 22, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request modifies the Activity Center to allow users to access not-running (inactive) jobs by reintroducing the activeOnly checkbox and propagating a new runningOnly parameter through job-related components.
- Updated job fetching in osparc/store/Jobs.js to use a unified endpoint with a runningOnly filter.
- Added a runningOnly property to RunsTableModel and updated binding/constructor logic in RunsTable and RunsBrowser for better filtering.
- Adjusted ActivityOverview and API endpoint configuration to enable showing non-active job runs.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| osparc/store/Jobs.js | Updated fetchJobsActive to include a runningOnly parameter and changed the endpoint to getPageLatest. |
| osparc/jobs/RunsTableModel.js | Introduced a runningOnly property and updated job fetching functions to pass the filter value. |
| osparc/jobs/RunsTable.js | Modified constructor and property bindings to include runningOnly, enabling proper filtering from the table. |
| osparc/jobs/RunsBrowser.js | Added a running-only checkbox control and binding to the table model to toggle active-only filtering. |
| osparc/jobs/ActivityOverview.js | Updated RunsTable instantiation to use runningOnly = false, allowing display of non-active runs. |
| osparc/data/Resources.js | Adjusted API endpoint URL to include a runningOnly filter parameter for job run queries. |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/data/Resources.js:355
- Verify that the server-side endpoint for getPageLatest correctly handles the 'runningOnly' parameter, ensuring that the expected boolean value is processed appropriately.
url: statics.API + "/computations/-/iterations/latest?offset={offset}&limit={limit}&order_by=%7B%22field%22:%22submitted_at%22,%22direction%22:%22desc%22%7D&filter_only_running={runningOnly}"
services/static-webserver/client/source/class/osparc/jobs/RunsTableModel.js
Outdated
Show resolved
Hide resolved
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 1a9b912 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As found by @mguidon, jobs submitted from Sim4Life Desktop are not accessible if they are not active, mainly because in the Activity Center we only show the active runs and also they do not have a Project card were one could access them from the Activity Overview.
This PR brings back the
activeOnlycheckbox to the Activity Center.Related issue/s
How to test
Dev-ops