🐛Dask-sidecar: ignore unexpected key-value pairs in outputs json data + unreliable computational runs in on-demand clusters #7724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
requested review from
bisgaard-itis,
giancarloromeo,
matusdrobuliak66 and
wvangeit
sanderegg
added
a:dask-service
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7724 +/- ##
===========================================
- Coverage 87.40% 74.59% -12.81%
===========================================
Files 1838 1161 -677
Lines 71063 48589 -22474
Branches 1201 186 -1015
===========================================
- Hits 62110 36247 -25863
- Misses 8625 12298 +3673
+ Partials 328 44 -284
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
wvangeit
reviewed
May 22, 2025
bisgaard-itis
approved these changes
May 22, 2025
Contributor
bisgaard-itis
left a comment
bisgaard-itis
left a comment
There was a problem hiding this comment.
Thanks for the quick fix
GitHK
approved these changes
May 22, 2025
matusdrobuliak66
approved these changes
May 22, 2025
sanderegg
force-pushed
the
bugfix/dask/parsing-output-data
branch
2 times, most recently
from
6a213b0 to
26649b9
Compare
pcrespov
approved these changes
May 22, 2025
packages/dask-task-models-library/src/dask_task_models_library/container_tasks/io.py
Show resolved
Hide resolved
sanderegg
force-pushed
the
bugfix/dask/parsing-output-data
branch
from
26649b9 to
4ed2b2d
Compare
sanderegg
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
@wvangeit discovered an issue where unexpected key-values in
outputs.jsonwould fail a run.This PR fixes it and also improves on the error shown in the UI logs.
This PR also should fix the unreliability in on-demande computational clusters.
Schema Validation Improvements:
from_task_outputinio.pyto filter out any entries in the task output data that are not defined in the schema. This ensures only valid keys are retained.test_create_task_output_from_task_ignores_additional_entriesto verify that extra keys in task output files are ignored when creating task output data.Error Handling Enhancements:
get_errorsinerrors.pyto improve error message formatting by directly using the exception's string representation.UnboundPortErrorinparse_output_dataindask.py, ensuring unbound ports are properly reported with detailed error messages.Related issue/s
How to test
Dev-ops