Skip to content

Conversation

@wvangeit
Copy link
Contributor

What do these changes do?

Json schemas don't support 'float', but need 'number'.
The Create functions window of the frontend now returns 'number' in the function schemas

How to test

Create function on frontend, run function.

@wvangeit wvangeit added this to the Bazinga! milestone May 22, 2025
@wvangeit wvangeit self-assigned this May 22, 2025
@wvangeit wvangeit requested a review from odeimaiz as a code owner May 22, 2025 10:27
@wvangeit wvangeit added a:frontend issue affecting the front-end (area group) 🤖-automerge marks PR as ready to be merged for Mergify labels May 22, 2025
@wvangeit wvangeit requested review from alexpargon and pcrespov May 22, 2025 10:28
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply remove the "mapping", if there is no mapping needed

@wvangeit
Copy link
Contributor Author

simply remove the "mapping", if there is no mapping needed

Done

@odeimaiz
Copy link
Member

odeimaiz commented May 22, 2025

simply remove the "mapping", if there is no mapping needed

Done

But the mapping for data:*/* <-> FileID, was correct , wasn't it?

@wvangeit
Copy link
Contributor Author

simply remove the "mapping", if there is no mapping needed

Done

But the mapping for "data:/" <-> "FileID", was correct , wasn't it?

Yes, but afaik filepickers are not allowed atm?

@odeimaiz
Copy link
Member

simply remove the "mapping", if there is no mapping needed

Done

But the mapping for "data:/" <-> "FileID", was correct , wasn't it?

Yes, but afaik filepickers are not allowed atm?

Correct, I will rewrite the function you just removed, in a few days 👍

@wvangeit
Copy link
Contributor Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented May 22, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 9e9cc95

@wvangeit
Copy link
Contributor Author

simply remove the "mapping", if there is no mapping needed

Done

But the mapping for "data:/" <-> "FileID", was correct , wasn't it?

Yes, but afaik filepickers are not allowed atm?

Correct, I will rewrite the function you just removed, in a few days 👍

So you want me to put it back, or we leave it like this for now?

@sonarqubecloud
Copy link

@mergify mergify bot merged commit 9e9cc95 into ITISFoundation:master May 22, 2025
59 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@wvangeit wvangeit deleted the fix_functions_float branch August 5, 2025 09:39
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants