Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented May 22, 2025

What do these changes do?

This PR adds more contextual information to exceptions related to invalid invitations. The goal is to enhance logging output, making it easier to diagnose the root cause of such issues directly from the logs, without needing to inspect the codebase. Initial log review below revealed insufficient details, prompting this improvement.
image

Related issue/s

  • support email by user

How to test

None

Dev-ops

NOne

@pcrespov pcrespov self-assigned this May 22, 2025
@pcrespov pcrespov requested a review from odeimaiz May 22, 2025 12:13
@pcrespov pcrespov added this to the Bazinga! milestone May 22, 2025
@pcrespov pcrespov added a:doc documentation, reporting, admin tasks 🤖-automerge marks PR as ready to be merged for Mergify labels May 22, 2025
@pcrespov
Copy link
Member Author

@mergify queue

@pcrespov pcrespov enabled auto-merge (squash) May 22, 2025 12:14
@mergify
Copy link
Contributor

mergify bot commented May 22, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.17%. Comparing base (1d5454a) to head (b3cda53).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7727      +/-   ##
==========================================
- Coverage   87.37%   87.17%   -0.20%     
==========================================
  Files        1838     1430     -408     
  Lines       71155    59550   -11605     
  Branches     1201      604     -597     
==========================================
- Hits        62170    51912   -10258     
+ Misses       8655     7450    -1205     
+ Partials      330      188     -142     
Flag Coverage Δ
integrationtests 64.47% <50.00%> (-0.02%) ⬇️
unittests 86.24% <75.00%> (-0.35%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.20% <ø> (ø)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.89% <ø> (-0.18%) ⬇️
agent 96.46% <ø> (ø)
api_server 91.58% <ø> (ø)
autoscaling 96.07% <ø> (ø)
catalog 92.29% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 91.67% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.78% <ø> (ø)
director_v2 90.99% <ø> (-0.05%) ⬇️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.18% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 89.13% <ø> (+0.10%) ⬆️
storage 87.56% <ø> (+0.07%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.72% <75.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5454a...b3cda53. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov added the t:maintenance Some planned maintenance work label May 22, 2025
@sonarqubecloud
Copy link

@pcrespov pcrespov merged commit e8ce837 into ITISFoundation:master May 22, 2025
93 of 95 checks passed
@pcrespov pcrespov deleted the mai/invitations branch May 22, 2025 17:07
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:doc documentation, reporting, admin tasks t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants