-
Notifications
You must be signed in to change notification settings - Fork 32
🐛On-demand computational backend failing #7735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛On-demand computational backend failing #7735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves debugging and logging workflows across multiple services and includes a critical fix for on-demand computational clusters by supplying missing environment variables and volume mounts for the Dask scheduler sidecar.
- Introduces shared data volume and environment variables for
dask-sidecarto ensure proper scheduling on on-demand clusters - Refactors
get_scheduler_urlfor brevity and updates noise-reduction logic for third-party loggers - Reorganizes imports and adjusts HTTP error response code for consistency
Reviewed Changes
Copilot reviewed 6 out of 22 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| services/clusters-keeper/src/simcore_service_clusters_keeper/utils/dask.py | Inlined return in get_scheduler_url |
| services/clusters-keeper/src/simcore_service_clusters_keeper/data/docker-compose.yml | Added shared volume/env for dask-sidecar; updated LOG_LEVEL |
| services/clusters-keeper/src/simcore_service_clusters_keeper/core/application.py | Added noise-reduction for verbose loggers |
| packages/service-library/src/servicelib/aiohttp/rest_responses.py | Moved RESPONSE_MODEL_POLICY import; clarified comment |
Files not reviewed (16)
- services/agent/docker/boot.sh: Language not supported
- services/api-server/docker/boot.sh: Language not supported
- services/autoscaling/docker/boot.sh: Language not supported
- services/catalog/docker/boot.sh: Language not supported
- services/clusters-keeper/docker/boot.sh: Language not supported
- services/dask-sidecar/docker/boot.sh: Language not supported
- services/datcore-adapter/docker/boot.sh: Language not supported
- services/director-v2/docker/boot.sh: Language not supported
- services/director/docker/boot.sh: Language not supported
- services/dynamic-scheduler/docker/boot.sh: Language not supported
- services/dynamic-sidecar/docker/boot.sh: Language not supported
- services/efs-guardian/docker/boot.sh: Language not supported
- services/invitations/docker/boot.sh: Language not supported
- services/notifications/docker/boot.sh: Language not supported
- services/payments/docker/boot.sh: Language not supported
- services/resource-usage-tracker/docker/boot.sh: Language not supported
Comments suppressed due to low confidence (1)
services/clusters-keeper/src/simcore_service_clusters_keeper/data/docker-compose.yml:6
- The volume
computational_shared_datais referenced under the service but not declared in the top-levelvolumes:section, which will cause Docker Compose to fail. Please add avolumes:entry definingcomputational_shared_data:.
- - computational_shared_data:${SIDECAR_COMP_SERVICES_SHARED_FOLDER:-/home/scu/computational_shared_data}
services/clusters-keeper/src/simcore_service_clusters_keeper/data/docker-compose.yml
Show resolved
Hide resolved
services/clusters-keeper/src/simcore_service_clusters_keeper/core/application.py
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7735 +/- ##
===========================================
- Coverage 87.37% 66.82% -20.55%
===========================================
Files 1838 713 -1125
Lines 71156 33412 -37744
Branches 1201 174 -1027
===========================================
- Hits 62173 22328 -39845
- Misses 8653 11026 +2373
+ Partials 330 58 -272
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|



What do these changes do?
This pull request introduces several updates across multiple services to improve debugging workflows, enhance logging, and refine service configurations. The most significant changes include adding conditional logic for installing
debugpy, updating Python debug options, reducing noisy loggers, and modifying service-specific configurations and the potential bugfix for on-demand clusters that were missing some ENV variables for the dask-scheduler due to the changes in .Debugging Enhancements:
uvcommand before installingdebugpyin debug mode across multiple services. This ensures compatibility with environments whereuvis available. (services/agent/docker/boot.sh[1]services/api-server/docker/boot.sh[2] and others)-Xfrozen_modules=offoption for better debugging support in services. (services/agent/docker/boot.sh[1]services/api-server/docker/boot.sh[2] and others)Logging Improvements:
aiobotocore,aio_pika) by dynamically adjusting their log levels based on the root logger's configuration. (services/clusters-keeper/src/simcore_service_clusters_keeper/core/application.pyservices/clusters-keeper/src/simcore_service_clusters_keeper/core/application.pyL26-R46)Configuration Updates:
dask-sidecarin thedocker-compose.ymlfile to support computational shared data. (services/clusters-keeper/src/simcore_service_clusters_keeper/data/docker-compose.yml[1] [2], a.k.a. the fix.Related issue/s
How to test
Dev-ops