Skip to content

♻️ removed unrequited assert #7754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2025
Merged

♻️ removed unrequited assert #7754

merged 4 commits into from
May 27, 2025

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented May 26, 2025 •
edited
Loading

What do these changes do?

This is not required and will be removed since it raises errors in development.

Related issue/s

How to test

Dev-ops

@GitHK GitHK self-assigned this May 26, 2025
@GitHK GitHK added this to the Bazinga! milestone May 26, 2025
@GitHK GitHK added the a:dynamic-sidecar dynamic-sidecar service label May 26, 2025
@GitHK GitHK marked this pull request as ready for review May 26, 2025 11:39
@GitHK GitHK requested a review from pcrespov as a code owner May 26, 2025 11:39
@codecov
Copy link

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.47%. Comparing base (da1e85f) to head (88b942d).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7754      +/-   ##
==========================================
- Coverage   86.79%   86.47%   -0.32%     
==========================================
  Files        1841     1433     -408     
  Lines       71501    59873   -11628     
  Branches     1214      616     -598     
==========================================
- Hits        62062    51778   -10284     
+ Misses       9096     7895    -1201     
+ Partials      343      200     -143
Flag Coverage Δ
integrationtests 64.34% <ø> (-0.03%) ⬇️
unittests 86.19% <ø> (-0.37%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 71.88% <ø> (+0.01%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.95% <ø> (-0.18%) ⬇️
agent 96.29% <ø> (ø)
api_server 91.77% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.25% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.67% <ø> (+0.22%) ⬆️
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 90.96% <ø> (-0.06%) ⬇️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.14% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.00% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 88.87% <ø> (-0.22%) ⬇️
storage 87.71% <ø> (-0.08%) ⬇️
webclient ∅ <ø> (∅)
webserver 83.94% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1e85f...88b942d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sanderegg
sanderegg approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@GitHK
Copy link
Contributor Author

GitHK commented May 27, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented May 27, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label May 27, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify
Copy link
Contributor

mergify bot commented May 27, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@GitHK
Copy link
Contributor Author

GitHK commented May 27, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented May 27, 2025

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request.

@mergify
Copy link
Contributor

mergify bot commented May 27, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at ac9806f

@mergify mergify bot merged commit ac9806f into ITISFoundation:master May 27, 2025
96 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@GitHK GitHK

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:dynamic-sidecar dynamic-sidecar service

Projects

None yet

Milestone

Bazinga!

Development

Successfully merging this pull request may close these issues.

4 participants

@GitHK @pcrespov @sanderegg @matusdrobuliak66