🐛 Fix errors observed in front-end due to the HTTP reason attribute and new lines
#7755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
added
the
a:webserver
pcrespov
requested review from
GitHK,
matusdrobuliak66 and
sanderegg
as code owners
Member
Author
|
@mergify queue |
Contributor
🛑 The pull request has been merged manuallyThe pull request has been merged manually at 5028e5a |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes front-end errors caused by newline characters in the HTTP reason attribute by sanitizing these messages. Key changes include:
- Replacing newline characters in error messages within the exception class.
- Applying a similar sanitization in the error response factory to prevent HTTP error misconfiguration.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/web/server/src/simcore_service_webserver/exporter/exceptions.py | Introduces message sanitization in the HTTP exception initialization |
| services/web/server/src/simcore_service_webserver/exception_handling/_factory.py | Applies newline replacement for HTTP reason in the JSON response factory |
Comments suppressed due to low confidence (1)
services/web/server/src/simcore_service_webserver/exception_handling/_factory.py:44
- Ensure that the error message sanitization is consistent across the codebase; if similar logic is used elsewhere, consider centralizing this functionality to prevent future discrepancies.
reason=error.message.replace("\n", " ") if error.message else None,
services/web/server/src/simcore_service_webserver/exporter/exceptions.py
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7755 +/- ##
==========================================
- Coverage 87.34% 83.80% -3.54%
==========================================
Files 1841 701 -1140
Lines 71456 33286 -38170
Branches 1214 174 -1040
==========================================
- Hits 62410 27895 -34515
+ Misses 8703 5333 -3370
+ Partials 343 58 -285
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
GitHK
approved these changes
May 26, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Found some more fixes for invalid HTTP
reasonattribute observed in the front-end:Related issue/s
How to test
Dev-ops