Skip to content

🐛 Fix errors observed in front-end due to the HTTP reason attribute and new lines #7755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2025
Merged

🐛 Fix errors observed in front-end due to the HTTP reason attribute and new lines #7755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a1f358
fixes raised error
pcrespov May 26, 2025
fd79f8c
doc
pcrespov May 26, 2025
206fa0d
other
pcrespov May 26, 2025
89be8b1
Merge branch 'master' into fix/reason-and-new-lines
mergify[bot] May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions services/web/server/src/simcore_service_webserver/exception_handling/_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
_logger = logging.getLogger(__name__)


_STATUS_CODE_TO_HTTP_ERRORS: dict[
int, type[web.HTTPError]
] = get_all_aiohttp_http_exceptions(web.HTTPError)
_STATUS_CODE_TO_HTTP_ERRORS: dict[int, type[web.HTTPError]] = (
get_all_aiohttp_http_exceptions(web.HTTPError)
)


class _DefaultDict(dict):
Expand All @@ -40,7 +40,8 @@ def create_error_response(error: ErrorGet, status_code: int) -> web.Response:
return web.json_response(
data={"error": error.model_dump(exclude_unset=True, mode="json")},
dumps=json_dumps,
reason=error.message,
# NOTE: Multiline not allowed in HTTP reason attribute (aiohttp now raises ValueError)
reason=error.message.replace("\n", " ") if error.message else None,
status=status_code,
)

Expand Down
3 changes: 2 additions & 1 deletion services/web/server/src/simcore_service_webserver/exporter/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ class SDSException(HTTPBadRequest): # pylint: disable=too-many-ancestors
"""Basic exception for errors raised inside the module"""

def __init__(self, message: str):
super().__init__(reason=message)
# Multiline not allowed in HTTP reason attribute
super().__init__(reason=message.replace("\n", " ") if message else None)
Loading