Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jun 3, 2025

What do these changes do?

  • Limit the number of inputs passed via the POST /v0/functions/{function_id}:map endpoint in the api server to 50 before the release

Related issue/s

How to test

Dev-ops

@bisgaard-itis bisgaard-itis self-assigned this Jun 3, 2025
@bisgaard-itis bisgaard-itis added this to the Bazinga! milestone Jun 3, 2025
@bisgaard-itis bisgaard-itis marked this pull request as ready for review June 3, 2025 13:59
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (071b9ec) to head (f9d7c78).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7801      +/-   ##
==========================================
+ Coverage   86.75%   88.23%   +1.48%     
==========================================
  Files        1850     1464     -386     
  Lines       71887    60907   -10980     
  Branches     1218      476     -742     
==========================================
- Hits        62365    53743    -8622     
+ Misses       9180     7043    -2137     
+ Partials      342      121     -221     
Flag Coverage Δ
integrationtests 64.19% <ø> (-0.01%) ⬇️
unittests 87.96% <100.00%> (+1.45%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.14% <100.00%> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.15% <ø> (+0.05%) ⬆️
agent 96.29% <ø> (ø)
api_server 91.69% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.29% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 91.10% <ø> (ø)
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.08% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.00% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 89.09% <ø> (ø)
storage 87.71% <ø> (-0.04%) ⬇️
webclient ∅ <ø> (∅)
webserver 83.74% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071b9ec...f9d7c78. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis bisgaard-itis changed the title 7799 limit number of accepted jobs in api server map Limit the number of accepted jobs in the api-server's POST /v0/functions/{function_id}:map endpoint Jun 3, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this fit with pagination limits?

@bisgaard-itis
Copy link
Contributor Author

how does this fit with pagination limits?

The list I am limiting here is an input (provided by the user), so I don't see any connection with pagination limits.

@bisgaard-itis bisgaard-itis requested a review from wvangeit June 4, 2025 07:58
@bisgaard-itis bisgaard-itis enabled auto-merge (squash) June 4, 2025 08:48
@bisgaard-itis
Copy link
Contributor Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@bisgaard-itis bisgaard-itis added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 4, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

@bisgaard-itis bisgaard-itis merged commit 169d99e into ITISFoundation:master Jun 4, 2025
95 checks passed
@bisgaard-itis bisgaard-itis deleted the 7799-limit-number-of-accepted-jobs-in-api-server-map branch June 4, 2025 10:42
@bisgaard-itis bisgaard-itis added the release Preparation for pre-release/release label Jun 5, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:apiserver api-server service Meta-modeling release Preparation for pre-release/release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit number of jobs accepted my map endpoint in api-server

5 participants