🎨 [Frontend] New icons: Hypertools, More, New Folder #7805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the icon sources for several frontend elements by replacing hardcoded paths with externally hosted URLs. Key changes include:
- Replacing the old hardcoded "diagram.png" icon in study utilities with a constant reference to the new pipeline icon.
- Updating the StudyUI model to define new constant URLs for Hypertool and Pipeline icons.
- Adjusting icon sizes and alignment in dashboard components (SearchBarFilter, ResourceBrowserFilter, and NewPlusMenu) to match the updated assets.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/study/Utils.js | Replaced hardcoded pipeline icon path with a constant from StudyUI. |
| services/static-webserver/client/source/class/osparc/data/model/StudyUI.js | Updated Hypertool icon from a function to a constant URL and added the Pipeline icon URL. |
| services/static-webserver/client/source/class/osparc/dashboard/SearchBarFilter.js | Adjusted icon size and usage for the Hypertools filter button. |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserFilter.js | Updated Hypertools icon and applied explicit padding adjustments for alignment. |
| services/static-webserver/client/source/class/osparc/dashboard/NewPlusMenu.js | Introduced new constants for More and Folder icons; updated usage in menu button creation. |
Comments suppressed due to low confidence (4)
services/static-webserver/client/source/class/osparc/data/model/StudyUI.js:97
- Consider if converting HYPERTOOL_ICON from a function to a constant meets all use cases; if dynamic sizing is required for different contexts, a functional approach might be preferable.
HYPERTOOL_ICON: "https://raw.githubusercontent.com/ZurichMedTech/s4l-assets/refs/heads/main/app/icons/hypertool.png",
services/static-webserver/client/source/class/osparc/dashboard/SearchBarFilter.js:281
- Ensure that the new size (18) for the Hypertools icon aligns with the overall dashboard design specifications and does not introduce layout inconsistencies.
osparc.utils.Utils.replaceIconWithThumbnail(hypertoolTypeButton, osparc.data.model.StudyUI.HYPERTOOL_ICON, 18);
services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserFilter.js:426
- [nitpick] Validate that the explicit padding adjustments for the Hypertools button provide consistent alignment across different screen sizes and icon assets.
button.set({ paddingLeft: 5, paddingTop: 0, paddingBottom: 0, });
services/static-webserver/client/source/class/osparc/dashboard/NewPlusMenu.js:159
- Confirm that passing null for the icon in createMenuButton is safe and that the subsequent explicit icon setting via setIcon fully covers all UI scenarios.
control = this.self().createMenuButton(null, this.tr("New Folder"));
matusdrobuliak66
approved these changes
Jun 4, 2025
GitHK
approved these changes
Jun 4, 2025
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 071b9ec |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR makes some icons point to their new sources. Affected icons:
Hypertools,More,New FolderRelated issue/s
How to test
Dev-ops