Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 4, 2025

What do these changes do?

A second app is going to make into sim4life.lite: sim4life.framework (the sim4life that supports plugins).

In order the frontend to support it, it needs to be listed in the New Menu. This PR updated the default plus button config (this config can be overridden in the DB).

Bonus:

s4l_framework

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Jun 4, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Second service on S4L.lite 🎨 [Frontend] Second service on Sim4Life.lite Jun 4, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Second service on Sim4Life.lite 🎨 [Frontend] Second app on Sim4Life.lite Jun 4, 2025
@odeimaiz odeimaiz requested a review from Copilot June 4, 2025 08:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for a second app (sim4life.framework) in sim4life.lite by updating the plus button configuration.

  • Added a new configuration entry with resourceType, expectedKey, title, and newStudyLabel for sim4life.framework.
  • Updated the ui_config.json to include the new menu option for the additional app.

@odeimaiz odeimaiz marked this pull request as ready for review June 4, 2025 08:39
@mguidon
Copy link
Member

mguidon commented Jun 4, 2025

The icon will ultimately be coming from the image labels, right?

@odeimaiz
Copy link
Member Author

odeimaiz commented Jun 4, 2025

The icon will ultimately be coming from the image labels, right?

Correct

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jun 4, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Jun 4, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2025

queue

🛑 The pull request has been synchronized by a user

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 4, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #7807 has been manually updated.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@odeimaiz
Copy link
Member Author

odeimaiz commented Jun 4, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2025

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests

@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

@odeimaiz odeimaiz enabled auto-merge (squash) June 4, 2025 15:34
@matusdrobuliak66 matusdrobuliak66 disabled auto-merge June 4, 2025 15:48
@matusdrobuliak66 matusdrobuliak66 removed the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 4, 2025
@odeimaiz odeimaiz merged commit c6d1b64 into ITISFoundation:master Jun 4, 2025
58 checks passed
matusdrobuliak66 added a commit to matusdrobuliak66/osparc-simcore that referenced this pull request Jun 5, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conversation Window in TIP needs some love

5 participants