Add function error handler to api server 🎨 #7810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parc-simcore into function_cache_check_success
wvangeit
requested review from
giancarloromeo,
matusdrobuliak66 and
sanderegg
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7810 +/- ##
==========================================
+ Coverage 86.74% 88.21% +1.46%
==========================================
Files 1850 1465 -385
Lines 71936 60982 -10954
Branches 1218 476 -742
==========================================
- Hits 62403 53796 -8607
+ Misses 9191 7065 -2126
+ Partials 342 121 -221
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pcrespov
approved these changes
Jun 4, 2025
...es/api-server/src/simcore_service_api_server/exceptions/handlers/_handler_function_errors.py
Show resolved
Hide resolved
sanderegg
approved these changes
Jun 4, 2025
Contributor
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3c20e92 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The function api now returns cleaner error message when exceptions are thrown in the webserver etc. E.g in case access is denied, inputs don't follow the schema, etc.
Based on MB's suggestion on how to this, i.e. by adding a function error handler.
How to test
E.g. run a function with inputs that don't match the json schema, you should now get a clean error code and message
Dev-ops
No changes