Skip to content

🎨 Improves webserver's exception handling to enhance diagnoses of catalog's client errors #7817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 4, 2025
Merged

🎨 Improves webserver's exception handling to enhance diagnoses of catalog's client errors #7817

merged 5 commits into from
Jun 4, 2025

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 4, 2025 •
edited
Loading

What do these changes do?

This PR refines the error handling logic using catalog._cotnroller_rest_excetpions._handler_catalog_client_errors to log detail troubleshooting information for diagnostics while keeping (for now), the current behavior:

  • If the catalog service responds with a 404, the webserver REST API returns a 404.
  • If the catalog service responds with any other error, it is translated into a 503 by the webserver REST API

IMO the current logic is overly coarse—many 4XX errors may indicate client-side issues rather than catalog unavailability, but we will wait until we see the errors to enhance that.

Related issue/s

How to test

Dev-ops

@pcrespov pcrespov self-assigned this Jun 4, 2025
@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs release Preparation for pre-release/release labels Jun 4, 2025
@pcrespov pcrespov added this to the Bazinga! milestone Jun 4, 2025
@pcrespov pcrespov changed the title WIP: Mai/log catalog failure 🎨 Improves webserver's exception handling for better diagnostics of catalog's client errors Jun 4, 2025
@pcrespov pcrespov changed the title 🎨 Improves webserver's exception handling for better diagnostics of catalog's client errors 🎨 Improves webserver's exception handling to enhance diagnoses of catalog's client errors Jun 4, 2025
@pcrespov pcrespov marked this pull request as ready for review June 4, 2025 17:43
@codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.58%. Comparing base (c6d1b64) to head (0040fc5).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7817      +/-   ##
==========================================
- Coverage   85.80%   82.58%   -3.22%     
==========================================
  Files        1850      703    -1147     
  Lines       71910    33579   -38331     
  Branches     1218      176    -1042     
==========================================
- Hits        61700    27732   -33968     
+ Misses       9868     5789    -4079     
+ Partials      342       58     -284
Flag Coverage Δ
integrationtests 64.17% <66.66%> (+3.82%) ⬆️
unittests 86.81% <66.66%> (+0.70%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.01% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.74% <ø> (-7.60%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.34% <ø> (-1.74%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 83.74% <66.66%> (-0.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d1b64...0040fc5. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

matusdrobuliak66
matusdrobuliak66 approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov merged commit bfb0c98 into ITISFoundation:master Jun 4, 2025
92 of 95 checks passed
@pcrespov pcrespov deleted the mai/log-catalog-failure branch June 4, 2025 18:35
@pcrespov pcrespov restored the mai/log-catalog-failure branch June 4, 2025 18:35
@pcrespov pcrespov deleted the mai/log-catalog-failure branch June 4, 2025 18:35
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

@wvangeit wvangeit Awaiting requested review from wvangeit

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@pcrespov pcrespov

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs release Preparation for pre-release/release

Projects

None yet

Milestone

Bazinga!

Development

Successfully merging this pull request may close these issues.

2 participants

@pcrespov @matusdrobuliak66