✨Add docker healthcheck of Simcore Traefik container #7820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
the
a:infra+ops
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a Docker healthcheck to the Simcore Traefik container to automatically detect hangs and trigger restarts.
- Introduces a
healthcheckblock with atraefik healthcheckcommand against thepingentrypoint - Sets intervals, timeouts, retries, and start-up timing for the check
Comments suppressed due to low confidence (1)
services/docker-compose.yml:1411
- The
start_intervalkey is not a valid Docker healthcheck option; Docker Compose supports onlyinterval,timeout,retries, andstart_period. Please remove or correct this entry.
start_interval: 1s
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7820 +/- ##
==========================================
+ Coverage 86.74% 86.76% +0.02%
==========================================
Files 1850 1843 -7
Lines 71934 71744 -190
Branches 1218 1218
==========================================
- Hits 62398 62250 -148
+ Misses 9194 9152 -42
Partials 342 342
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 873fe78 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
adds a docker healthcheck for simcore traefik container --> to ensure that the container is restarted in case it hangs.
Related issue/s
How to test
Dev-ops