-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] Second app on Sim4Life.lite (II) #7823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Second app on Sim4Life.lite (II) #7823
Conversation
…arc-simcore into enh/second-app-for-s4l-lite
…arc-simcore into enh/second-app-for-s4l-lite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the frontend to support a second app (“Sim4Life.framework”) in the lite version and refines user avatar and comment handling, plus updates editor subtitles to link to docs.
- Adds a new service entry for Sim4Life.framework in UI config
- Refactors Avatar.emailToThumbnail into a single function signature
- Caches failed user fetches and improves comment UI fallback
- Switches subtitle labels to LinkLabel and adds doc URLs in editors
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/resource/osparc/ui_config.json | Added Sim4Life.framework button entry |
| services/static-webserver/client/source/class/osparc/utils/Avatar.js | Merged getUrl into emailToThumbnail signature |
| services/static-webserver/client/source/class/osparc/store/Users.js | Introduced __unknowns list to skip repeated fetches |
| services/static-webserver/client/source/class/osparc/info/CommentUI.js | Improved default avatar/username fallback handling |
| services/static-webserver/client/source/class/osparc/editor/TextEditor.js | Changed subtitle to LinkLabel and simplified layout |
| services/static-webserver/client/source/class/osparc/editor/MarkdownEditor.js | Added external Markdown docs URL to subtitle |
| services/static-webserver/client/source/class/osparc/editor/HtmlEditor.js | Added external HTML docs URL to subtitle |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/info/CommentUI.js:115
- [nitpick] You removed the initial placeholder avatar and username. It’s better to set a default thumbnail and label immediately (before async resolution) to avoid blank UI while the fetch is pending.
const thumbnail = this.getChildControl("thumbnail");
services/static-webserver/client/source/class/osparc/store/Users.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/editor/TextEditor.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/editor/TextEditor.js
Show resolved
Hide resolved
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
|
This pull request has been removed from the queue for the following reason: Pull request #7823 has been dequeued. The pull request rule doesn't match anymore. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |



What do these changes do?
Same as #7807, but this time the Avatar.js (Bonus) works for all cases
Fixed:

Related issue/s
How to test
Dev-ops