Generate unique Celery worker name #7827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7827 +/- ##
==========================================
- Coverage 85.06% 84.96% -0.11%
==========================================
Files 1803 1807 +4
Lines 70100 69649 -451
Branches 1218 1218
==========================================
- Hits 59628 59174 -454
- Misses 10130 10134 +4
+ Partials 342 341 -1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces changes to generate unique Celery worker names by appending a Task ID to hostnames in the Docker Compose configuration.
- Updated hostname for "sto-worker" to include Task.ID
- Updated hostname for "sto-worker-cpu-bound" to include Task.ID
Comments suppressed due to low confidence (2)
services/docker-compose.yml:1249
- Appending Task.ID to the hostname enhances uniqueness. Please verify that Task.ID is consistently available and fits the overall worker naming scheme.
hostname: "sto-worker-{{.Node.Hostname}}-{{.Task.Slot}}-{{.Task.ID}}"
services/docker-compose.yml:1259
- The updated hostname for CPU-bound workers now includes Task.ID, which should help in generating unique worker names. Ensure that this new format is compatible with all related systems.
hostname: "sto-worker-cpu-bound-{{.Node.Hostname}}-{{.Task.Slot}}-{{.Task.ID}}"
giancarloromeo
requested review from
YuryHrytsuk,
mrnicegyu11 and
sanderegg
as code owners
giancarloromeo
requested review from
GitHK,
bisgaard-itis,
matusdrobuliak66 and
pcrespov
YuryHrytsuk
reviewed
Jun 5, 2025
pcrespov
reviewed
Jun 5, 2025
GitHK
approved these changes
Jun 5, 2025
sanderegg
approved these changes
Jun 5, 2025
|
Contributor
Author
|
@Mergifyio queue |
Contributor
🟠 Waiting for conditions to match
|
giancarloromeo
merged commit 5cc2bdd
into
ITISFoundation:master
141 of 149 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR introduces changes to generate unique Celery worker names by appending a Task ID to hostnames in the Docker Compose configuration.
As you can see in the example below, the Celery workers won't collide anymore: e.g.
celery@sto-worker-romeo-wkst-l854yndv9usxrqv1ccxn4vat5.The issue happened during roll-out of new version of worker services.
Related issue/s
How to test
Dev-ops