♻️ Towards a common long_running_tasks interface

[GitHK]

What do these changes do?

NOTE: PR is very noisy, but functionally nothing changed.

I'm trying to make the long_running_tasks more resilient. These will be of great help in the future and move in the direction of the restorability milestone.
This is the second in a series of PRs.

Here I am merely centralising the imports from the common library in servicelib.
In future PRs I will also make sure the interfaces are the same by inheriting form a common one.

Related issue/s

• dynamic scheduler: extract scheduling logic and move it away from director-v2 #5632

How to test

Dev-ops

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.37%. Comparing base (e5c45de) to head (73c7bba).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7833      +/-   ##
==========================================
- Coverage   87.89%   86.37%   -1.52%     
==========================================
  Files        1836     1444     -392     
  Lines       70999    60423   -10576     
  Branches     1219      618     -601     
==========================================
- Hits        62402    52190   -10212     
+ Misses       8254     8033     -221     
+ Partials      343      200     -143     

Flag	Coverage Δ
integrationtests	64.24% <92.00%> (+<0.01%)	⬆️
unittests	86.06% <100.00%> (-0.42%)	⬇️

Components	Coverage Δ
api	76.84% <ø> (ø)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	71.81% <100.00%> (-0.05%)	⬇️
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	85.16% <ø> (+0.05%)	⬆️
agent	96.29% <ø> (ø)
api_server	91.74% <100.00%> (ø)
autoscaling	96.03% <ø> (ø)
catalog	92.29% <ø> (ø)
clusters_keeper	99.13% <ø> (ø)
dask_sidecar	91.79% <ø> (ø)
datcore_adapter	97.94% <ø> (ø)
director	76.73% <ø> (ø)
director_v2	91.06% <100.00%> (-0.02%)	⬇️
dynamic_scheduler	96.69% <ø> (ø)
dynamic_sidecar	90.09% <100.00%> (+<0.01%)	⬆️
efs_guardian	89.65% <ø> (ø)
invitations	93.00% <ø> (ø)
payments	92.57% <ø> (ø)
resource_usage_tracker	88.87% <ø> (-0.11%)	⬇️
storage	87.53% <ø> (ø)
webclient	∅ <ø> (∅)
webserver	83.72% <100.00%> (-3.88%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c45de...73c7bba. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[giancarloromeo]

Good. What about having a single interface for these "long running tasks", Celery ones and any other future implementation?

[GitHK]

Good. What about having a single interface for these "long running tasks", Celery ones and any other future implementation?

I'm trying to move in this direction, currently I'm tying to unify the aiohttp and fastapi versions of this code.
I want to merge it into one implementation.
I think we can have what you request in the future. I'm refactoring to go in that direction while still keeping the long_running_tasks everywhere.

[GitHK]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 4777c9e

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud